[GitHub] [cassandra] bereng commented on a change in pull request #811: CASSANDRA-16249: Fix the missing bb position in getUnsignedShort

[GitBox <gi...@apache.org>]

bereng commented on a change in pull request #811:
URL: https://github.com/apache/cassandra/pull/811#discussion_r519558501



##########
File path: src/java/org/apache/cassandra/db/marshal/ByteBufferAccessor.java
##########
@@ -193,7 +193,7 @@ public short getShort(ByteBuffer value, int offset)
     @Override
     public int getUnsignedShort(ByteBuffer value, int offset)
     {
-        return ByteBufferUtil.getUnsignedShort(value, offset);
+        return ByteBufferUtil.getUnsignedShort(value, value.position() + offset);

Review comment:
       Good catch. The only one that's missing it.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org