You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "WillAyd (via GitHub)" <gi...@apache.org> on 2025/03/14 20:32:32 UTC

[PR] GH-45798: [C++] Add extension directory to Meson [arrow]

WillAyd opened a new pull request, #45799:
URL: https://github.com/apache/arrow/pull/45799

   ### Rationale for this change
   
   Continues growing Meson support in Arrow
   
   ### What changes are included in this PR?
   
   Added the extension directory to the Meson configuration
   
   ### Are these changes tested?
   
   Yes
   
   ### Are there any user-facing changes?
   
   No
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] GH-45798: [C++] Add extension directory to Meson [arrow]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #45799:
URL: https://github.com/apache/arrow/pull/45799#issuecomment-2725691607

   :warning: GitHub issue #45798 **has been automatically assigned in GitHub** to PR creator.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] GH-45798: [C++] Add extension directory to Meson [arrow]

Posted by "lidavidm (via GitHub)" <gi...@apache.org>.
lidavidm commented on code in PR #45799:
URL: https://github.com/apache/arrow/pull/45799#discussion_r2166792084


##########
cpp/src/arrow/extension/meson.build:
##########
@@ -0,0 +1,36 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements.  See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership.  The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License.  You may obtain a copy of the License at
+#
+#   http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied.  See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+canonical_extension_tests = ['bool8_test.cc', 'json_test.cc', 'uuid_test.cc']
+
+if needs_json
+    canonical_extension_tests += [
+        'fixed_shape_tensor_test.cc',

Review Comment:
   Sorry, I totally missed this. What was the problem in the end?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] GH-45798: [C++] Add extension directory to Meson [arrow]

Posted by "WillAyd (via GitHub)" <gi...@apache.org>.
WillAyd commented on code in PR #45799:
URL: https://github.com/apache/arrow/pull/45799#discussion_r1996244744


##########
cpp/src/arrow/extension/meson.build:
##########
@@ -0,0 +1,36 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements.  See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership.  The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License.  You may obtain a copy of the License at
+#
+#   http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied.  See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+canonical_extension_tests = ['bool8_test.cc', 'json_test.cc', 'uuid_test.cc']
+
+if needs_json
+    canonical_extension_tests += [
+        'fixed_shape_tensor_test.cc',

Review Comment:
   This all compiles fine, although at runtime I am getting a few test failures:
   
   ```sh
   [ RUN      ] TestExtensionType.RoundtripBatch
   ../src/arrow/testing/gtest_util.cc:560: Failure
   Failed
   Left schema: f0: extension<arrow.fixed_shape_tensor[value_type=int64, shape=[3,4], dim_names=[x,y]]>
   Right schema: f0: fixed_size_list<item: int64>[12]
   -- metadata --
   ARROW:extension:metadata: {"shape":[3,4],"dim_names":["x","y"]}
   ARROW:extension:name: arrow.fixed_shape_tensor
   
   ../src/arrow/testing/gtest_util.cc:560: Failure
   Failed
   Left schema: f0: extension<arrow.fixed_shape_tensor[value_type=int64, shape=[3,4], dim_names=[x,y]]>
   Right schema: f0: fixed_size_list<item: int64>[12]
   -- metadata --
   ARROW:extension:metadata: {"shape":[3,4],"dim_names":["x","y"]}
   ARROW:extension:name: arrow.fixed_shape_tensor
   
   ...
   
   [ RUN      ] TestExtensionType.RoundtripBatchFromTensor
   ../src/arrow/testing/gtest_util.cc:560: Failure
   Failed
   Left schema: f0: extension<arrow.fixed_shape_tensor[value_type=int64, shape=[3,4], dim_names=[x,y]]>
   -- metadata --
   ARROW:extension:metadata: {"shape":[3,4],"dim_names":["x","y"]}
   ARROW:extension:name: arrow.fixed_shape_tensor
   Right schema: f0: fixed_size_list<item: int64>[12]
   -- metadata --
   ARROW:extension:metadata: {"shape":[3,4],"dim_names":["x","y"]}
   ARROW:extension:name: arrow.fixed_shape_tensor
   ARROW:extension:metadata: {"shape":[3,4],"dim_names":["x","y"]}
   ARROW:extension:name: arrow.fixed_shape_tensor
   
   ...
   
   [ RUN      ] OpaqueType.BatchRoundTrip
   ../src/arrow/extension/opaque_test.cc:191: Failure
   Expected equality of these values:
     *batch->schema()
       Which is: field: extension<arrow.opaque[storage_type=binary, type_name=geometry, vendor_name=adbc.postgresql]>
     *written->schema()
       Which is: field: binary
   ```
   
   @lidavidm I see you are the only one who has touched the opaque file. Any idea what I should be looking at to debug the opaque test failure?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] GH-45798: [C++] Add extension directory to Meson [arrow]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #45799:
URL: https://github.com/apache/arrow/pull/45799#issuecomment-2725691623

   :warning: GitHub issue #45798 **has no components**, please add labels for components.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org