You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@ignite.apache.org by GitBox <gi...@apache.org> on 2022/10/10 07:41:02 UTC
[GitHub] [ignite] liyuj opened a new pull request, #10297: IGNITE-17857 The native client does not need to verify the configurat…
liyuj opened a new pull request, #10297:
URL: https://github.com/apache/ignite/pull/10297
…ion consistency of the DeploymentSpi
Thank you for submitting the pull request to the Apache Ignite.
In order to streamline the review of the contribution
we ask you to ensure the following steps have been taken:
### The Contribution Checklist
- [ ] There is a single JIRA ticket related to the pull request.
- [ ] The web-link to the pull request is attached to the JIRA ticket.
- [ ] The JIRA ticket has the _Patch Available_ state.
- [ ] The pull request body describes changes that have been made.
The description explains _WHAT_ and _WHY_ was made instead of _HOW_.
- [ ] The pull request title is treated as the final commit message.
The following pattern must be used: `IGNITE-XXXX Change summary` where `XXXX` - number of JIRA issue.
- [ ] A reviewer has been mentioned through the JIRA comments
(see [the Maintainers list](https://cwiki.apache.org/confluence/display/IGNITE/How+to+Contribute#HowtoContribute-ReviewProcessandMaintainers))
- [ ] The pull request has been checked by the Teamcity Bot and
the `green visa` attached to the JIRA ticket (see [TC.Bot: Check PR](https://mtcga.gridgain.com/prs.html))
### Notes
- [How to Contribute](https://cwiki.apache.org/confluence/display/IGNITE/How+to+Contribute)
- [Coding abbreviation rules](https://cwiki.apache.org/confluence/display/IGNITE/Abbreviation+Rules)
- [Coding Guidelines](https://cwiki.apache.org/confluence/display/IGNITE/Coding+Guidelines)
- [Apache Ignite Teamcity Bot](https://cwiki.apache.org/confluence/display/IGNITE/Apache+Ignite+Teamcity+Bot)
If you need any help, please email dev@ignite.apache.org or ask anу advice on http://asf.slack.com _#ignite_ channel.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ignite] sergey-chugunov-1985 commented on a diff in pull request #10297: IGNITE-17857 The native client does not need to verify the configurat…
Posted by GitBox <gi...@apache.org>.
sergey-chugunov-1985 commented on code in PR #10297:
URL: https://github.com/apache/ignite/pull/10297#discussion_r994503163
##########
modules/core/src/main/java/org/apache/ignite/spi/deployment/local/LocalDeploymentSpi.java:
##########
@@ -65,7 +65,7 @@
* @see org.apache.ignite.spi.deployment.DeploymentSpi
*/
@IgniteSpiMultipleInstancesSupport(true)
-@IgniteSpiConsistencyChecked(optional = false)
+@IgniteSpiConsistencyChecked(optional = false, checkClient = false)
Review Comment:
@liyuj , I suggest a different fix here: removing this annotation completely from **LocalDeploymentSpi** class.
The root cause of the issue you've reported is that **LocalDeploymentSpi** is set by default if no other DeploymentSpi is specified.
But **LocalDeploymentSpi** according to its name is local and doesn't interfere with any other DeploymentSpi configured anywhere in the cluster. So the right fix for the issue would be to remove this annotation (**IgniteSpiConsistencyChecked**) from **LocalDeploymentSpi** completely and revert any changes on **UriDeploymentSpi**.
Also it would be great if you turn your reproducer into a regular Ignite test. A good place for the test is **ignite-urideploy** module where **UriDeploymentSpi** is available.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ignite] asfgit closed pull request #10297: IGNITE-17857 The native client does not need to verify the configurat…
Posted by GitBox <gi...@apache.org>.
asfgit closed pull request #10297: IGNITE-17857 The native client does not need to verify the configurat…
URL: https://github.com/apache/ignite/pull/10297
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ignite] sergey-chugunov-1985 commented on a diff in pull request #10297: IGNITE-17857 The native client does not need to verify the configurat…
Posted by GitBox <gi...@apache.org>.
sergey-chugunov-1985 commented on code in PR #10297:
URL: https://github.com/apache/ignite/pull/10297#discussion_r994503163
##########
modules/core/src/main/java/org/apache/ignite/spi/deployment/local/LocalDeploymentSpi.java:
##########
@@ -65,7 +65,7 @@
* @see org.apache.ignite.spi.deployment.DeploymentSpi
*/
@IgniteSpiMultipleInstancesSupport(true)
-@IgniteSpiConsistencyChecked(optional = false)
+@IgniteSpiConsistencyChecked(optional = false, checkClient = false)
Review Comment:
@liyuj , I suggest a different fix here: removing this annotation completely from **LocalDeploymentSpi** class.
The root cause of the issue you've reported is that **LocalDeploymentSpi** is set by default if no other DeploymentSpi is specified.
But **LocalDeploymentSpi** according to its name is local and doesn't interfere with any other DeploymentSpi configured anywhere in the cluster. So the right fix for the issue would be to remove this annotation (**IgniteSpiConsistencyChecked**) from **LocalDeploymentSpi** completely and revert any changes on **UriDeploymentSpi**.
It would also be great if you turn your reproducer into a regular Ignite test. A good place for the test is **ignite-urideploy** module where **UriDeploymentSpi** is available.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org