[jira] [Commented] (ZOOKEEPER-1460) IPv6 literal address not supported for quorum members

["Chris Nauroth (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/ZOOKEEPER-1460?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14988514#comment-14988514 ] 

Chris Nauroth commented on ZOOKEEPER-1460:
------------------------------------------

Hi [~rakeshr].  Were you interested in getting this into the soon-to-come 3.4.7 release?  I believe [~rgs] plans to get rolling on that soon.  I'm not sure I'll have time myself to rebase this patch for branch-3.4 soon enough.  If someone else would like to do so, then I'd be happy to squeeze in a code review though.

> IPv6 literal address not supported for quorum members
> -----------------------------------------------------
>
>                 Key: ZOOKEEPER-1460
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1460
>             Project: ZooKeeper
>          Issue Type: Bug
>          Components: quorum
>    Affects Versions: 3.4.3
>            Reporter: Chris Dolan
>            Assignee: Joseph Walton
>             Fix For: 3.5.2, 3.6.0
>
>         Attachments: ZOOKEEPER-1460-accept-square-bracket-delimited-IPv6-literals.2.diff, ZOOKEEPER-1460-accept-square-bracket-delimited-IPv6-literals.diff, ZOOKEEPER-1460-for-3.5.0.patch, ZOOKEEPER-1460.003.patch
>
>
> Via code inspection, I see that the "server.nnn" configuration key does not support literal IPv6 addresses because the property value is split on ":". In v3.4.3, the problem is in QuorumPeerConfig:
> {noformat}
> String parts[] = value.split(":");
> InetSocketAddress addr = new InetSocketAddress(parts[0],
>                         Integer.parseInt(parts[1]));
> {noformat}
> In the current trunk (http://svn.apache.org/viewvc/zookeeper/trunk/src/java/main/org/apache/zookeeper/server/quorum/QuorumPeer.java?view=markup) this code has been refactored into QuorumPeer.QuorumServer, but the bug remains:
> {noformat}
> String serverClientParts[] = addressStr.split(";");
> String serverParts[] = serverClientParts[0].split(":");
> addr = new InetSocketAddress(serverParts[0],
>                         Integer.parseInt(serverParts[1]));
> {noformat}
> This bug probably affects very few users because most will naturally use a hostname rather than a literal IP address. But given that IPv6 addresses are supported for clients via ZOOKEEPER-667 it seems that server support should be fixed too.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)