You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by "azexcy (via GitHub)" <gi...@apache.org> on 2023/11/10 02:11:14 UTC
[PR] Add tinyint decode at MppdbDecodingPlugin [shardingsphere]
azexcy opened a new pull request, #28998:
URL: https://github.com/apache/shardingsphere/pull/28998
Related #22500.
Changes proposed in this pull request:
- Add tinyint decode at MppdbDecodingPlugin
---
Before committing this PR, I'm sure that I have checked the following options:
- [ ] My code follows the [code of conduct](https://shardingsphere.apache.org/community/en/involved/conduct/code/) of this project.
- [ ] I have self-reviewed the commit code.
- [ ] I have (or in comment I request) added corresponding labels for the pull request.
- [ ] I have passed maven check locally : `./mvnw clean install -B -T1C -Dmaven.javadoc.skip -Dmaven.jacoco.skip -e`.
- [ ] I have made corresponding changes to the documentation.
- [ ] I have added corresponding unit tests for my changes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Notify the CDC Client if streaming stopped due to exception [shardingsphere]
Posted by "sandynz (via GitHub)" <gi...@apache.org>.
sandynz commented on code in PR #28998:
URL: https://github.com/apache/shardingsphere/pull/28998#discussion_r1389053369
##########
kernel/data-pipeline/scenario/cdc/core/src/main/java/org/apache/shardingsphere/data/pipeline/cdc/core/job/CDCJob.java:
##########
@@ -200,6 +202,10 @@ public void onFailure(final Throwable throwable) {
log.error("onFailure, {} task execute failed.", identifier, throwable);
String jobId = jobItemContext.getJobId();
jobAPI.updateJobItemErrorMessage(jobId, jobItemContext.getShardingItem(), throwable);
+ if (jobItemContext.getSink() instanceof CDCSocketSink) {
+ CDCSocketSink cdcSink = (CDCSocketSink) jobItemContext.getSink();
+ cdcSink.getChannel().writeAndFlush(CDCResponseUtils.failed("", "", throwable.getMessage()));
Review Comment:
Looks channel.writeAndFlush might be invoked in multi-thread here (CDCSocketSink is still running), could we verify the thread-safety of channel write?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add tinyint decode at MppdbDecodingPlugin [shardingsphere]
Posted by "azexcy (via GitHub)" <gi...@apache.org>.
azexcy commented on PR #28998:
URL: https://github.com/apache/shardingsphere/pull/28998#issuecomment-1805169479
refer https://docs.opengauss.org/en/docs/3.0.0/docs/BriefTutorial/data-types.html tinyint
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Notify the CDC Client if streaming stopped due to exception [shardingsphere]
Posted by "sandynz (via GitHub)" <gi...@apache.org>.
sandynz merged PR #28998:
URL: https://github.com/apache/shardingsphere/pull/28998
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add tinyint decode at MppdbDecodingPlugin [shardingsphere]
Posted by "azexcy (via GitHub)" <gi...@apache.org>.
azexcy commented on PR #28998:
URL: https://github.com/apache/shardingsphere/pull/28998#issuecomment-1805171258
<img width="717" alt="image" src="https://github.com/apache/shardingsphere/assets/101622833/cd5573db-450a-47e5-a397-4e9ac946d522">
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Notify the CDC Client if streaming stopped due to exception [shardingsphere]
Posted by "sandynz (via GitHub)" <gi...@apache.org>.
sandynz commented on code in PR #28998:
URL: https://github.com/apache/shardingsphere/pull/28998#discussion_r1389121495
##########
kernel/data-pipeline/scenario/cdc/core/src/main/java/org/apache/shardingsphere/data/pipeline/cdc/core/job/CDCJob.java:
##########
@@ -200,6 +202,10 @@ public void onFailure(final Throwable throwable) {
log.error("onFailure, {} task execute failed.", identifier, throwable);
String jobId = jobItemContext.getJobId();
jobAPI.updateJobItemErrorMessage(jobId, jobItemContext.getShardingItem(), throwable);
+ if (jobItemContext.getSink() instanceof CDCSocketSink) {
+ CDCSocketSink cdcSink = (CDCSocketSink) jobItemContext.getSink();
+ cdcSink.getChannel().writeAndFlush(CDCResponseUtils.failed("", "", throwable.getMessage()));
Review Comment:
OK
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Notify the CDC Client if streaming stopped due to exception [shardingsphere]
Posted by "azexcy (via GitHub)" <gi...@apache.org>.
azexcy commented on code in PR #28998:
URL: https://github.com/apache/shardingsphere/pull/28998#discussion_r1389094618
##########
kernel/data-pipeline/scenario/cdc/core/src/main/java/org/apache/shardingsphere/data/pipeline/cdc/core/job/CDCJob.java:
##########
@@ -200,6 +202,10 @@ public void onFailure(final Throwable throwable) {
log.error("onFailure, {} task execute failed.", identifier, throwable);
String jobId = jobItemContext.getJobId();
jobAPI.updateJobItemErrorMessage(jobId, jobItemContext.getShardingItem(), throwable);
+ if (jobItemContext.getSink() instanceof CDCSocketSink) {
+ CDCSocketSink cdcSink = (CDCSocketSink) jobItemContext.getSink();
+ cdcSink.getChannel().writeAndFlush(CDCResponseUtils.failed("", "", throwable.getMessage()));
Review Comment:
I find some related question:
https://lists.jboss.org/pipermail/netty-users/2008-November/000045.html
https://stackoverflow.com/questions/23161608/is-netty4-channelhandlercontext-write-thread-safe
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org