You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hbase.apache.org by "Zhihong Ted Yu (JIRA)" <ji...@apache.org> on 2012/06/27 00:20:42 UTC

[jira] [Created] (HBASE-6277) Metrics for scan object are overwritten when restart() is called

Zhihong Ted Yu created HBASE-6277:
-------------------------------------

             Summary: Metrics for scan object are overwritten when restart() is called
                 Key: HBASE-6277
                 URL: https://issues.apache.org/jira/browse/HBASE-6277
             Project: HBase
          Issue Type: Bug
            Reporter: Zhihong Ted Yu


>From HBASE-4145:
There's an issue in {{TableRecordReaderImpl}}. Calling restart() does this:

{code}
public void restart(byte[] firstRow) throws IOException {
  currentScan = new Scan(scan);
{code}

Which by itself is fine since the metrics will be copied from *scan* to *currentScan*, except that it's *currentScan* that has the updated metrics not *scan*.

In other words, *currentScan* is the object that is used for scanning so it contains the metrics. If restart() is called, that object is overwritten by the original definition of the {{Scan}}. I think to fix this we could grab the metrics from *currentScan* first then set them back on the new object.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira