You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@geode.apache.org by Bruce Schuchardt <bs...@pivotal.io> on 2019/11/05 18:45:45 UTC
bug fix needed for release/1.11.0
The PR for GEODE-6661 introduced a problem in SSL communications that
needs to be fixed. It changed SSL handshakes to use a temporary buffer
that's discarded when the handshake completes, but sometimes this buffer
contains application data that must be retained. This seems to be
causing our Benchmark SSL test failures in CI.
I'm preparing a fix. We can either revert the PR for GEODE-6661 on that
branch or cherry-pick the correction when it's ready.
Re: Odg: bug fix needed for release/1.11.0
Posted by Owen Nichols <on...@pivotal.io>.
Also perhaps some people are waiting to see how the fix actually fares in the develop pipeline, which we won’t know until around 4 or 5PM today...
> On Nov 6, 2019, at 9:44 AM, Mark Hanson <mh...@pivotal.io> wrote:
>
> Thanks Mario. Your vote reminded me not all voters are in the PST time zone.. Pardon my thoughtlessness..
>
> Voting closes at 12pm PST
>
>
>> On Nov 6, 2019, at 9:33 AM, Mario Ivanac <ma...@est.tech> wrote:
>>
>> +1 for bringing this fix to release/1.11.0
>> ________________________________
>> Šalje: Mark Hanson <mh...@pivotal.io>
>> Poslano: 6. studenog 2019. 18:28
>> Prima: dev@geode.apache.org <de...@geode.apache.org>
>> Predmet: Re: bug fix needed for release/1.11.0
>>
>> Any other votes? I have 2 people in favor.
>>
>> Voting will close at noon.
>>
>> Thanks,
>> Mark
>>
>>> On Nov 6, 2019, at 8:00 AM, Bruce Schuchardt <bs...@pivotal.io> wrote:
>>>
>>> The fix for this problem is in the CI pipeline today: https://concourse.apachegeode-ci.info/teams/main/pipelines/apache-develop-main/jobs/Build/builds/1341
>>>
>>> On 11/5/19 10:49 AM, Owen Nichols wrote:
>>>> +1 for bringing this fix to release/1.11.0 (after it has passed Benchmarks on develop)
>>>>
>>>>> On Nov 5, 2019, at 10:45 AM, Bruce Schuchardt <bs...@pivotal.io> wrote:
>>>>>
>>>>> The PR for GEODE-6661 introduced a problem in SSL communications that needs to be fixed. It changed SSL handshakes to use a temporary buffer that's discarded when the handshake completes, but sometimes this buffer contains application data that must be retained. This seems to be causing our Benchmark SSL test failures in CI.
>>>>>
>>>>> I'm preparing a fix. We can either revert the PR for GEODE-6661 on that branch or cherry-pick the correction when it's ready.
>>>>>
>>
>
Re: Odg: bug fix needed for release/1.11.0
Posted by Ernest Burghardt <eb...@pivotal.io>.
we could just use GMT (Geode Mean Time)
On Wed, Nov 6, 2019 at 9:45 AM Mark Hanson <mh...@pivotal.io> wrote:
> Thanks Mario. Your vote reminded me not all voters are in the PST time
> zone.. Pardon my thoughtlessness..
>
> Voting closes at 12pm PST
>
>
> > On Nov 6, 2019, at 9:33 AM, Mario Ivanac <ma...@est.tech> wrote:
> >
> > +1 for bringing this fix to release/1.11.0
> > ________________________________
> > Šalje: Mark Hanson <mh...@pivotal.io>
> > Poslano: 6. studenog 2019. 18:28
> > Prima: dev@geode.apache.org <de...@geode.apache.org>
> > Predmet: Re: bug fix needed for release/1.11.0
> >
> > Any other votes? I have 2 people in favor.
> >
> > Voting will close at noon.
> >
> > Thanks,
> > Mark
> >
> >> On Nov 6, 2019, at 8:00 AM, Bruce Schuchardt <bs...@pivotal.io>
> wrote:
> >>
> >> The fix for this problem is in the CI pipeline today:
> https://concourse.apachegeode-ci.info/teams/main/pipelines/apache-develop-main/jobs/Build/builds/1341
> >>
> >> On 11/5/19 10:49 AM, Owen Nichols wrote:
> >>> +1 for bringing this fix to release/1.11.0 (after it has passed
> Benchmarks on develop)
> >>>
> >>>> On Nov 5, 2019, at 10:45 AM, Bruce Schuchardt <bs...@pivotal.io>
> wrote:
> >>>>
> >>>> The PR for GEODE-6661 introduced a problem in SSL communications that
> needs to be fixed. It changed SSL handshakes to use a temporary buffer
> that's discarded when the handshake completes, but sometimes this buffer
> contains application data that must be retained. This seems to be causing
> our Benchmark SSL test failures in CI.
> >>>>
> >>>> I'm preparing a fix. We can either revert the PR for GEODE-6661 on
> that branch or cherry-pick the correction when it's ready.
> >>>>
> >
>
>
Re: Odg: bug fix needed for release/1.11.0
Posted by Mark Hanson <mh...@pivotal.io>.
Thanks Mario. Your vote reminded me not all voters are in the PST time zone.. Pardon my thoughtlessness..
Voting closes at 12pm PST
> On Nov 6, 2019, at 9:33 AM, Mario Ivanac <ma...@est.tech> wrote:
>
> +1 for bringing this fix to release/1.11.0
> ________________________________
> Šalje: Mark Hanson <mh...@pivotal.io>
> Poslano: 6. studenog 2019. 18:28
> Prima: dev@geode.apache.org <de...@geode.apache.org>
> Predmet: Re: bug fix needed for release/1.11.0
>
> Any other votes? I have 2 people in favor.
>
> Voting will close at noon.
>
> Thanks,
> Mark
>
>> On Nov 6, 2019, at 8:00 AM, Bruce Schuchardt <bs...@pivotal.io> wrote:
>>
>> The fix for this problem is in the CI pipeline today: https://concourse.apachegeode-ci.info/teams/main/pipelines/apache-develop-main/jobs/Build/builds/1341
>>
>> On 11/5/19 10:49 AM, Owen Nichols wrote:
>>> +1 for bringing this fix to release/1.11.0 (after it has passed Benchmarks on develop)
>>>
>>>> On Nov 5, 2019, at 10:45 AM, Bruce Schuchardt <bs...@pivotal.io> wrote:
>>>>
>>>> The PR for GEODE-6661 introduced a problem in SSL communications that needs to be fixed. It changed SSL handshakes to use a temporary buffer that's discarded when the handshake completes, but sometimes this buffer contains application data that must be retained. This seems to be causing our Benchmark SSL test failures in CI.
>>>>
>>>> I'm preparing a fix. We can either revert the PR for GEODE-6661 on that branch or cherry-pick the correction when it's ready.
>>>>
>
Odg: bug fix needed for release/1.11.0
Posted by Mario Ivanac <ma...@est.tech>.
+1 for bringing this fix to release/1.11.0
________________________________
Šalje: Mark Hanson <mh...@pivotal.io>
Poslano: 6. studenog 2019. 18:28
Prima: dev@geode.apache.org <de...@geode.apache.org>
Predmet: Re: bug fix needed for release/1.11.0
Any other votes? I have 2 people in favor.
Voting will close at noon.
Thanks,
Mark
> On Nov 6, 2019, at 8:00 AM, Bruce Schuchardt <bs...@pivotal.io> wrote:
>
> The fix for this problem is in the CI pipeline today: https://concourse.apachegeode-ci.info/teams/main/pipelines/apache-develop-main/jobs/Build/builds/1341
>
> On 11/5/19 10:49 AM, Owen Nichols wrote:
>> +1 for bringing this fix to release/1.11.0 (after it has passed Benchmarks on develop)
>>
>>> On Nov 5, 2019, at 10:45 AM, Bruce Schuchardt <bs...@pivotal.io> wrote:
>>>
>>> The PR for GEODE-6661 introduced a problem in SSL communications that needs to be fixed. It changed SSL handshakes to use a temporary buffer that's discarded when the handshake completes, but sometimes this buffer contains application data that must be retained. This seems to be causing our Benchmark SSL test failures in CI.
>>>
>>> I'm preparing a fix. We can either revert the PR for GEODE-6661 on that branch or cherry-pick the correction when it's ready.
>>>
Re: bug fix needed for release/1.11.0
Posted by Mark Hanson <mh...@pivotal.io>.
Based on the lack of “-1” votes, I have cherry-picked the change…
Thanks,
Mark
> On Nov 7, 2019, at 8:54 AM, Bruce Schuchardt <bs...@pivotal.io> wrote:
>
> The change passed in SSL benchmark testing and can be cherry-picked into the release branch. The Benchmark job as a whole failed due to perf degradation with the Security Manager, but that's a different set of tests.
>
>
> On 11/6/19 3:57 PM, Helena Bales wrote:
>> +1 to cherry-picking the fix.
>>
>> The sha hasn't made it to benchmarks yet due to an issue with CI losing
>> resource refs that were needed to keep it moving through the pipeline. The
>> next commit is still about an hour away from triggering benchmarks.
>> In my manual benchmarking of this change, I found that it resolved the
>> issue with SSL and passed the benchmarks. Obviously we still need to
>> confirm that it works through the main pipeline, but I feel confident that
>> it will pass the benchmark job.
>>
>> Thanks,
>> Helena Bales (they/them)
>>
>> On Wed, Nov 6, 2019 at 9:28 AM Mark Hanson <mh...@pivotal.io> wrote:
>>
>>> Any other votes? I have 2 people in favor.
>>>
>>> Voting will close at noon.
>>>
>>> Thanks,
>>> Mark
>>>
>>>> On Nov 6, 2019, at 8:00 AM, Bruce Schuchardt <bs...@pivotal.io>
>>> wrote:
>>>> The fix for this problem is in the CI pipeline today:
>>> https://concourse.apachegeode-ci.info/teams/main/pipelines/apache-develop-main/jobs/Build/builds/1341
>>>> On 11/5/19 10:49 AM, Owen Nichols wrote:
>>>>> +1 for bringing this fix to release/1.11.0 (after it has passed
>>> Benchmarks on develop)
>>>>>> On Nov 5, 2019, at 10:45 AM, Bruce Schuchardt <bs...@pivotal.io>
>>> wrote:
>>>>>> The PR for GEODE-6661 introduced a problem in SSL communications that
>>> needs to be fixed. It changed SSL handshakes to use a temporary buffer
>>> that's discarded when the handshake completes, but sometimes this buffer
>>> contains application data that must be retained. This seems to be causing
>>> our Benchmark SSL test failures in CI.
>>>>>> I'm preparing a fix. We can either revert the PR for GEODE-6661 on
>>> that branch or cherry-pick the correction when it's ready.
>>>
Re: bug fix needed for release/1.11.0
Posted by Darrel Schneider <ds...@pivotal.io>.
+1 to include the fix
On Thu, Nov 7, 2019 at 8:54 AM Bruce Schuchardt <bs...@pivotal.io>
wrote:
> The change passed in SSL benchmark testing and can be cherry-picked into
> the release branch. The Benchmark job as a whole failed due to perf
> degradation with the Security Manager, but that's a different set of tests.
>
>
> On 11/6/19 3:57 PM, Helena Bales wrote:
> > +1 to cherry-picking the fix.
> >
> > The sha hasn't made it to benchmarks yet due to an issue with CI losing
> > resource refs that were needed to keep it moving through the pipeline.
> The
> > next commit is still about an hour away from triggering benchmarks.
> > In my manual benchmarking of this change, I found that it resolved the
> > issue with SSL and passed the benchmarks. Obviously we still need to
> > confirm that it works through the main pipeline, but I feel confident
> that
> > it will pass the benchmark job.
> >
> > Thanks,
> > Helena Bales (they/them)
> >
> > On Wed, Nov 6, 2019 at 9:28 AM Mark Hanson <mh...@pivotal.io> wrote:
> >
> >> Any other votes? I have 2 people in favor.
> >>
> >> Voting will close at noon.
> >>
> >> Thanks,
> >> Mark
> >>
> >>> On Nov 6, 2019, at 8:00 AM, Bruce Schuchardt <bs...@pivotal.io>
> >> wrote:
> >>> The fix for this problem is in the CI pipeline today:
> >>
> https://concourse.apachegeode-ci.info/teams/main/pipelines/apache-develop-main/jobs/Build/builds/1341
> >>> On 11/5/19 10:49 AM, Owen Nichols wrote:
> >>>> +1 for bringing this fix to release/1.11.0 (after it has passed
> >> Benchmarks on develop)
> >>>>> On Nov 5, 2019, at 10:45 AM, Bruce Schuchardt <
> bschuchardt@pivotal.io>
> >> wrote:
> >>>>> The PR for GEODE-6661 introduced a problem in SSL communications that
> >> needs to be fixed. It changed SSL handshakes to use a temporary buffer
> >> that's discarded when the handshake completes, but sometimes this buffer
> >> contains application data that must be retained. This seems to be
> causing
> >> our Benchmark SSL test failures in CI.
> >>>>> I'm preparing a fix. We can either revert the PR for GEODE-6661 on
> >> that branch or cherry-pick the correction when it's ready.
> >>
>
Re: bug fix needed for release/1.11.0
Posted by Bruce Schuchardt <bs...@pivotal.io>.
The change passed in SSL benchmark testing and can be cherry-picked into
the release branch. The Benchmark job as a whole failed due to perf
degradation with the Security Manager, but that's a different set of tests.
On 11/6/19 3:57 PM, Helena Bales wrote:
> +1 to cherry-picking the fix.
>
> The sha hasn't made it to benchmarks yet due to an issue with CI losing
> resource refs that were needed to keep it moving through the pipeline. The
> next commit is still about an hour away from triggering benchmarks.
> In my manual benchmarking of this change, I found that it resolved the
> issue with SSL and passed the benchmarks. Obviously we still need to
> confirm that it works through the main pipeline, but I feel confident that
> it will pass the benchmark job.
>
> Thanks,
> Helena Bales (they/them)
>
> On Wed, Nov 6, 2019 at 9:28 AM Mark Hanson <mh...@pivotal.io> wrote:
>
>> Any other votes? I have 2 people in favor.
>>
>> Voting will close at noon.
>>
>> Thanks,
>> Mark
>>
>>> On Nov 6, 2019, at 8:00 AM, Bruce Schuchardt <bs...@pivotal.io>
>> wrote:
>>> The fix for this problem is in the CI pipeline today:
>> https://concourse.apachegeode-ci.info/teams/main/pipelines/apache-develop-main/jobs/Build/builds/1341
>>> On 11/5/19 10:49 AM, Owen Nichols wrote:
>>>> +1 for bringing this fix to release/1.11.0 (after it has passed
>> Benchmarks on develop)
>>>>> On Nov 5, 2019, at 10:45 AM, Bruce Schuchardt <bs...@pivotal.io>
>> wrote:
>>>>> The PR for GEODE-6661 introduced a problem in SSL communications that
>> needs to be fixed. It changed SSL handshakes to use a temporary buffer
>> that's discarded when the handshake completes, but sometimes this buffer
>> contains application data that must be retained. This seems to be causing
>> our Benchmark SSL test failures in CI.
>>>>> I'm preparing a fix. We can either revert the PR for GEODE-6661 on
>> that branch or cherry-pick the correction when it's ready.
>>
Re: bug fix needed for release/1.11.0
Posted by Helena Bales <hb...@pivotal.io>.
+1 to cherry-picking the fix.
The sha hasn't made it to benchmarks yet due to an issue with CI losing
resource refs that were needed to keep it moving through the pipeline. The
next commit is still about an hour away from triggering benchmarks.
In my manual benchmarking of this change, I found that it resolved the
issue with SSL and passed the benchmarks. Obviously we still need to
confirm that it works through the main pipeline, but I feel confident that
it will pass the benchmark job.
Thanks,
Helena Bales (they/them)
On Wed, Nov 6, 2019 at 9:28 AM Mark Hanson <mh...@pivotal.io> wrote:
> Any other votes? I have 2 people in favor.
>
> Voting will close at noon.
>
> Thanks,
> Mark
>
> > On Nov 6, 2019, at 8:00 AM, Bruce Schuchardt <bs...@pivotal.io>
> wrote:
> >
> > The fix for this problem is in the CI pipeline today:
> https://concourse.apachegeode-ci.info/teams/main/pipelines/apache-develop-main/jobs/Build/builds/1341
> >
> > On 11/5/19 10:49 AM, Owen Nichols wrote:
> >> +1 for bringing this fix to release/1.11.0 (after it has passed
> Benchmarks on develop)
> >>
> >>> On Nov 5, 2019, at 10:45 AM, Bruce Schuchardt <bs...@pivotal.io>
> wrote:
> >>>
> >>> The PR for GEODE-6661 introduced a problem in SSL communications that
> needs to be fixed. It changed SSL handshakes to use a temporary buffer
> that's discarded when the handshake completes, but sometimes this buffer
> contains application data that must be retained. This seems to be causing
> our Benchmark SSL test failures in CI.
> >>>
> >>> I'm preparing a fix. We can either revert the PR for GEODE-6661 on
> that branch or cherry-pick the correction when it's ready.
> >>>
>
>
Re: bug fix needed for release/1.11.0
Posted by Mark Hanson <mh...@pivotal.io>.
Any other votes? I have 2 people in favor.
Voting will close at noon.
Thanks,
Mark
> On Nov 6, 2019, at 8:00 AM, Bruce Schuchardt <bs...@pivotal.io> wrote:
>
> The fix for this problem is in the CI pipeline today: https://concourse.apachegeode-ci.info/teams/main/pipelines/apache-develop-main/jobs/Build/builds/1341
>
> On 11/5/19 10:49 AM, Owen Nichols wrote:
>> +1 for bringing this fix to release/1.11.0 (after it has passed Benchmarks on develop)
>>
>>> On Nov 5, 2019, at 10:45 AM, Bruce Schuchardt <bs...@pivotal.io> wrote:
>>>
>>> The PR for GEODE-6661 introduced a problem in SSL communications that needs to be fixed. It changed SSL handshakes to use a temporary buffer that's discarded when the handshake completes, but sometimes this buffer contains application data that must be retained. This seems to be causing our Benchmark SSL test failures in CI.
>>>
>>> I'm preparing a fix. We can either revert the PR for GEODE-6661 on that branch or cherry-pick the correction when it's ready.
>>>
Re: bug fix needed for release/1.11.0
Posted by Bruce Schuchardt <bs...@pivotal.io>.
The fix for this problem is in the CI pipeline today:
https://concourse.apachegeode-ci.info/teams/main/pipelines/apache-develop-main/jobs/Build/builds/1341
On 11/5/19 10:49 AM, Owen Nichols wrote:
> +1 for bringing this fix to release/1.11.0 (after it has passed Benchmarks on develop)
>
>> On Nov 5, 2019, at 10:45 AM, Bruce Schuchardt <bs...@pivotal.io> wrote:
>>
>> The PR for GEODE-6661 introduced a problem in SSL communications that needs to be fixed. It changed SSL handshakes to use a temporary buffer that's discarded when the handshake completes, but sometimes this buffer contains application data that must be retained. This seems to be causing our Benchmark SSL test failures in CI.
>>
>> I'm preparing a fix. We can either revert the PR for GEODE-6661 on that branch or cherry-pick the correction when it's ready.
>>
Re: bug fix needed for release/1.11.0
Posted by Owen Nichols <on...@pivotal.io>.
+1 for bringing this fix to release/1.11.0 (after it has passed Benchmarks on develop)
> On Nov 5, 2019, at 10:45 AM, Bruce Schuchardt <bs...@pivotal.io> wrote:
>
> The PR for GEODE-6661 introduced a problem in SSL communications that needs to be fixed. It changed SSL handshakes to use a temporary buffer that's discarded when the handshake completes, but sometimes this buffer contains application data that must be retained. This seems to be causing our Benchmark SSL test failures in CI.
>
> I'm preparing a fix. We can either revert the PR for GEODE-6661 on that branch or cherry-pick the correction when it's ready.
>