You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "kou (via GitHub)" <gi...@apache.org> on 2026/06/07 08:34:57 UTC
[PR] GH-50115: [Dev] Adjust GitHub Copilot configuration for preliminary reviews [arrow]
kou opened a new pull request, #50117:
URL: https://github.com/apache/arrow/pull/50117
### Rationale for this change
We tried auto GitHub Copilot reviews recently and discussed our experience for them:
https://lists.apache.org/thread/thq0dz19shxbrjypb81q5ltx8h0w54ob
We want to tune auto GitHub Copilot reviews:
* We don't need auto GitHub Copilot reviews for draft PR: https://lists.apache.org/thread/y7yc4yg9n4mdqd1y00w7s498y8m6yold
* GitHub Copilot review is too verbose: https://github.com/apache/arrow/pull/50023#issuecomment-4535261566
* We need to document the expectation for contributors responding to GitHub Copilot reviews: https://lists.apache.org/thread/wvhdqqtq2ndxxjnqwnj39xfcys21tpc4
### What changes are included in this PR?
* Disable auto GitHub Copilot reviews for draft PR
* Add code review instructions for GitHub Copilot
* Base text is generated by Gemini 3 Flash Preview and I adjusted it
### Are these changes tested?
No. We need to merge this to test this.
### Are there any user-facing changes?
No.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-50115: [Dev] Adjust GitHub Copilot configuration for preliminary reviews [arrow]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #50117:
URL: https://github.com/apache/arrow/pull/50117#issuecomment-4654725907
Revision: 802ef45e289ab17b7c0f7976bc65d5ca5a5209ff
Submitted crossbow builds: [ursacomputing/crossbow @ actions-51084d64f9](https://github.com/ursacomputing/crossbow/branches/all?query=actions-51084d64f9)
|Task|Status|
|----|------|
|preview-docs|[](https://github.com/ursacomputing/crossbow/actions/runs/27175363785/job/80222982205)|
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-50115: [Dev] Adjust GitHub Copilot configuration for preliminary reviews [arrow]
Posted by "conbench-apache-arrow[bot] (via GitHub)" <gi...@apache.org>.
conbench-apache-arrow[bot] commented on PR #50117:
URL: https://github.com/apache/arrow/pull/50117#issuecomment-4702319286
After merging your PR, Conbench analyzed the 4 benchmarking runs that have been run so far on merge-commit 4fce185a1a34dd6b409260c142e6e4e148f43995.
There were no benchmark performance regressions. 🎉
The [full Conbench report](https://github.com/apache/arrow/runs/81293547820) has more details. It also includes information about 4 possible false positives for unstable benchmarks that are known to sometimes produce them.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-50115: [Dev] Adjust GitHub Copilot configuration for preliminary reviews [arrow]
Posted by "kou (via GitHub)" <gi...@apache.org>.
kou commented on code in PR #50117:
URL: https://github.com/apache/arrow/pull/50117#discussion_r3391655886
##########
docs/source/developers/overview.rst:
##########
@@ -104,6 +104,10 @@ When contributing a patch, use this list as a checklist of Apache Arrow workflow
merged, this will be retained in the extended commit message.
* Make sure that your code **passes the unit tests**. You can find instructions how
to run the unit tests for each Arrow component in its respective README file.
+* In order to improve our code and your review experience, we have
+ enabled GitHub Copilot reviews to automate the first pass. Please
+ address all GitHub Copilot comments by either implementing them, or
+ explicitly responding and explaining why you chose not to.
Review Comment:
Thanks.
I've applied your suggestion.
Can we merge and try this configuration now?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-50115: [Dev] Adjust GitHub Copilot configuration for preliminary reviews [arrow]
Posted by "pitrou (via GitHub)" <gi...@apache.org>.
pitrou commented on code in PR #50117:
URL: https://github.com/apache/arrow/pull/50117#discussion_r3380731725
##########
docs/source/developers/overview.rst:
##########
@@ -104,6 +104,10 @@ When contributing a patch, use this list as a checklist of Apache Arrow workflow
merged, this will be retained in the extended commit message.
* Make sure that your code **passes the unit tests**. You can find instructions how
to run the unit tests for each Arrow component in its respective README file.
+* In order to improve our code and your review experience, we have
+ enabled GitHub Copilot reviews to automate the first pass. Please
+ address all GitHub Copilot comments by either implementing them, or
+ explicitly responding and explaining why you chose not to.
Review Comment:
Asking people to respond to Copilot comments is one more hurdle for contributors. Why is this important?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-50115: [Dev] Adjust GitHub Copilot configuration for preliminary reviews [arrow]
Posted by "kou (via GitHub)" <gi...@apache.org>.
kou commented on PR #50117:
URL: https://github.com/apache/arrow/pull/50117#issuecomment-4654713010
@github-actions crossbow submit preview-docs
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-50115: [Dev] Adjust GitHub Copilot configuration for preliminary reviews [arrow]
Posted by "raulcd (via GitHub)" <gi...@apache.org>.
raulcd commented on code in PR #50117:
URL: https://github.com/apache/arrow/pull/50117#discussion_r3386987709
##########
docs/source/developers/overview.rst:
##########
@@ -104,6 +104,10 @@ When contributing a patch, use this list as a checklist of Apache Arrow workflow
merged, this will be retained in the extended commit message.
* Make sure that your code **passes the unit tests**. You can find instructions how
to run the unit tests for each Arrow component in its respective README file.
+* In order to improve our code and your review experience, we have
+ enabled GitHub Copilot reviews to automate the first pass. Please
+ address all GitHub Copilot comments by either implementing them, or
+ explicitly responding and explaining why you chose not to.
Review Comment:
We can start with something a little more relaxed:
> Reviewers and contributors are encouraged to address valid suggestions; you don't need to respond to every comment, but please don't ignore them either.
And if we see that general Copilot comments are good (not that many hallucinations or repeated comments) we can revisit the phrasing.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-50115: [Dev] Adjust GitHub Copilot configuration for preliminary reviews [arrow]
Posted by "kou (via GitHub)" <gi...@apache.org>.
kou commented on PR #50117:
URL: https://github.com/apache/arrow/pull/50117#issuecomment-4654675173
@alamb Thanks for suggesting the sentence! I've added it!
FYI: I tried applying your suggestion in the mailing list by adding the following instruction:
> First-time contributors: For users new to this repository, explicitly instruct them to "Please check and address all review comments in this PR."
I think that most contributors don't read our documentation carefully... So notifying it by a PR comment may be better than documentation.
Anyway, both of them will be better than one of them. :-)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-50115: [Dev] Adjust GitHub Copilot configuration for preliminary reviews [arrow]
Posted by "pitrou (via GitHub)" <gi...@apache.org>.
pitrou commented on code in PR #50117:
URL: https://github.com/apache/arrow/pull/50117#discussion_r3386792606
##########
docs/source/developers/overview.rst:
##########
@@ -104,6 +104,10 @@ When contributing a patch, use this list as a checklist of Apache Arrow workflow
merged, this will be retained in the extended commit message.
* Make sure that your code **passes the unit tests**. You can find instructions how
to run the unit tests for each Arrow component in its respective README file.
+* In order to improve our code and your review experience, we have
+ enabled GitHub Copilot reviews to automate the first pass. Please
+ address all GitHub Copilot comments by either implementing them, or
+ explicitly responding and explaining why you chose not to.
Review Comment:
I think Arrow core developers are less likely to hallucinate than an LLM.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-50115: [Dev] Adjust GitHub Copilot configuration for preliminary reviews [arrow]
Posted by "kou (via GitHub)" <gi...@apache.org>.
kou merged PR #50117:
URL: https://github.com/apache/arrow/pull/50117
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-50115: [Dev] Adjust GitHub Copilot configuration for preliminary reviews [arrow]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #50117:
URL: https://github.com/apache/arrow/pull/50117#issuecomment-4641960175
:warning: GitHub issue #50115 **has been automatically assigned in GitHub** to PR creator.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-50115: [Dev] Adjust GitHub Copilot configuration for preliminary reviews [arrow]
Posted by "kou (via GitHub)" <gi...@apache.org>.
kou commented on code in PR #50117:
URL: https://github.com/apache/arrow/pull/50117#discussion_r3384708836
##########
docs/source/developers/overview.rst:
##########
@@ -104,6 +104,10 @@ When contributing a patch, use this list as a checklist of Apache Arrow workflow
merged, this will be retained in the extended commit message.
* Make sure that your code **passes the unit tests**. You can find instructions how
to run the unit tests for each Arrow component in its respective README file.
+* In order to improve our code and your review experience, we have
+ enabled GitHub Copilot reviews to automate the first pass. Please
+ address all GitHub Copilot comments by either implementing them, or
+ explicitly responding and explaining why you chose not to.
Review Comment:
I'm not sure whether this is one more hurdle or not. Contributors need to respond to comments from human reviewers. Are they different?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org