You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@trafficcontrol.apache.org by GitBox <gi...@apache.org> on 2019/04/18 20:47:14 UTC

[GitHub] [trafficcontrol] ocket8888 commented on a change in pull request #3501: [Ready for Review] Use of AngularJS markup in URL-valued attribute

ocket8888 commented on a change in pull request #3501: [Ready for Review] Use of AngularJS markup in URL-valued attribute
URL: https://github.com/apache/trafficcontrol/pull/3501#discussion_r276827664
 
 

 ##########
 File path: traffic_portal/app/src/common/modules/form/deliveryService/form.deliveryService.DNS.tpl.html
 ##########
 @@ -356,7 +356,7 @@ <h6>Note:</h6>
                             Enables/disables the Multi-Site Origin feature for this Delivery Service.
                             <br>
                             <br>
-                            <a href="https://traffic-control-cdn.readthedocs.io/en/latest/admin/traffic_ops/using.html#multi-site-origin" target="_blank">See Multi-Site Origin.</a>
+                            <a ng-href="https://traffic-control-cdn.readthedocs.io/en/latest/admin/traffic_ops/using.html#multi-site-origin" target="_blank">See Multi-Site Origin.</a>
 
 Review comment:
   This - and several others at first glance - does not appear to be using any AngularJS string interpolation (which is I think what you mean by "markup"?) so this is an unnecessary change.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services