You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@arrow.apache.org by "sgilmore10 (via GitHub)" <gi...@apache.org> on 2023/08/18 18:05:29 UTC
[GitHub] [arrow] sgilmore10 opened a new issue, #37251: [MATLAB] Remove `arrow.type.TemporalType` superclass temporarily
sgilmore10 opened a new issue, #37251:
URL: https://github.com/apache/arrow/issues/37251
### Describe the enhancement requested
Our original motivation for adding the super-class `arrow.type.TemporalType` in #37236 was to define a common implementation for extracting the `Unit` property from `TimestampType`, `Time32Type`, `Time64Type`, `Date32Type`, and `Date64Type`. However, this approach doesn't work because the `Unit` property on `Date32Type` and `Date64Type` is a `DateUnit`, while the `Unit` property on the other three types is a`TimeUnit`. This means we can't define a method for extracting the `Unit` property within `TemporalType`.
For now, we plan on removing the `TemporalType` class since it won't defined any shared functionality.
However, in the future, we would like add `TemporalType` back as a "mixin" class for type-checking purposes. We would also add a function called `arrow.type.isTemporal(arrowType)` that would return `true` if the `arrowType` class inherits from `TemporalType`.
### Component(s)
MATLAB
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@arrow.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kevingurney closed issue #37251: [MATLAB] Make `arrow.type.TemporalType` a "tag" class
Posted by "kevingurney (via GitHub)" <gi...@apache.org>.
kevingurney closed issue #37251: [MATLAB] Make `arrow.type.TemporalType` a "tag" class
URL: https://github.com/apache/arrow/issues/37251
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org