You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@cxf.apache.org by "Robert Liguori (JIRA)" <ji...@apache.org> on 2010/12/05 00:09:11 UTC

[jira] Created: (CXF-3165) SUN_TOOL_PATH references legacy vendor

SUN_TOOL_PATH references legacy vendor
--------------------------------------

                 Key: CXF-3165
                 URL: https://issues.apache.org/jira/browse/CXF-3165
             Project: CXF
          Issue Type: Improvement
    Affects Versions: 2.3.0
            Reporter: Robert Liguori
            Priority: Minor


Consider the Identifier  SUN_TOOL_PATH in the tool scripts.

Sun (as in SUN_TOOL_PATH) is now Oracle... this wasn't a good idea of putting the vendor's name in the the identifier name.

Consider renaming SUN_TOOL_PATH to JAVA_SE_TOOL_PATH or something similar.  Of course, Java SE is for JDK 1.6 and J2SE is for JDK 1.5. 

TOOL_PATH by itself, leaves confusion as the assumption may be for the CXF tool path, thus why SUN was probably added in the first place.

The recommendation is to make the update in all of the tool scripts (e.g. wsdl2java).

Thanks!

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Resolved: (CXF-3165) SUN_TOOL_PATH references legacy vendor

Posted by "Daniel Kulp (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/CXF-3165?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Daniel Kulp resolved CXF-3165.
------------------------------

       Resolution: Fixed
    Fix Version/s: 2.3.2
         Assignee: Daniel Kulp

I just renamed it to TOOLS_JAR (applicable to IBM jdk as well).

Also updated the text around the require JDK version.

> SUN_TOOL_PATH references legacy vendor
> --------------------------------------
>
>                 Key: CXF-3165
>                 URL: https://issues.apache.org/jira/browse/CXF-3165
>             Project: CXF
>          Issue Type: Improvement
>    Affects Versions: 2.3.0
>            Reporter: Robert Liguori
>            Assignee: Daniel Kulp
>            Priority: Minor
>             Fix For: 2.3.2
>
>
> Consider the Identifier  SUN_TOOL_PATH in the tool scripts.
> Sun (as in SUN_TOOL_PATH) is now Oracle... this wasn't a good idea of putting the vendor's name in the the identifier name.
> Consider renaming SUN_TOOL_PATH to JAVA_SE_TOOL_PATH or something similar.  Of course, Java SE is for JDK 1.6 and J2SE is for JDK 1.5. 
> TOOL_PATH by itself, leaves confusion as the assumption may be for the CXF tool path, thus why SUN was probably added in the first place.
> The recommendation is to make the update in all of the tool scripts (e.g. wsdl2java).
> Thanks!

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (CXF-3165) SUN_TOOL_PATH references legacy vendor

Posted by "Benson Margulies (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/CXF-3165?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12966958#action_12966958 ] 

Benson Margulies commented on CXF-3165:
---------------------------------------

1. It has to be sun because it is specific to Sun packages, as opposed to Apple or IBM.
2. The world is still full of 'Sun'. Java package names, Distro package names, etc.
3. Since Sun produced the package which this is aimed at, I don't see that it matters that the name changed.

> SUN_TOOL_PATH references legacy vendor
> --------------------------------------
>
>                 Key: CXF-3165
>                 URL: https://issues.apache.org/jira/browse/CXF-3165
>             Project: CXF
>          Issue Type: Improvement
>    Affects Versions: 2.3.0
>            Reporter: Robert Liguori
>            Priority: Minor
>
> Consider the Identifier  SUN_TOOL_PATH in the tool scripts.
> Sun (as in SUN_TOOL_PATH) is now Oracle... this wasn't a good idea of putting the vendor's name in the the identifier name.
> Consider renaming SUN_TOOL_PATH to JAVA_SE_TOOL_PATH or something similar.  Of course, Java SE is for JDK 1.6 and J2SE is for JDK 1.5. 
> TOOL_PATH by itself, leaves confusion as the assumption may be for the CXF tool path, thus why SUN was probably added in the first place.
> The recommendation is to make the update in all of the tool scripts (e.g. wsdl2java).
> Thanks!

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.