You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2022/10/05 20:04:33 UTC

[GitHub] [superset] kgabryje opened a new pull request, #21680: fix(native-filters): Range filter max/min default display value

kgabryje opened a new pull request, #21680:
URL: https://github.com/apache/superset/pull/21680

   ### SUMMARY
   When user added a range native filter with single value option (minimum or maximum) and a default value, the default value would be displayed incorrectly (even though the filter applied correct values). This PR fixes that behaviour
   
   ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
   Before:
   
   https://user-images.githubusercontent.com/15073128/193591149-6719bb6e-e44a-419f-b42d-4ca28ef4aeba.mov
   
   After:
   
   https://user-images.githubusercontent.com/15073128/193590816-d63a7d98-0198-4c97-954c-21945d1a1c56.mov
   
   
   ### TESTING INSTRUCTIONS
   1. Create a range native filter, select single value minimum or maximum and a default value
   2. Verify that the filter in the filter bar displays with correct default range
   3. Verify that filter is applied correctly to charts
   
   ### ADDITIONAL INFORMATION
   <!--- Check any relevant boxes with "x" -->
   <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
   - [ ] Has associated issue:
   - [ ] Required feature flags:
   - [ ] Changes UI
   - [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351))
     - [ ] Migration is atomic, supports rollback & is backwards-compatible
     - [ ] Confirm DB migration upgrade and downgrade tested
     - [ ] Runtime estimates and downtime expectations provided
   - [ ] Introduces new feature or API
   - [ ] Removes existing feature or API
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org