You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@hbase.apache.org by GitBox <gi...@apache.org> on 2021/01/04 19:20:43 UTC

[GitHub] [hbase] apurtell commented on pull request #2714: HBASE-25333 Add a yetus check to disable usage of VisibleForTesting a…

apurtell commented on pull request #2714:
URL: https://github.com/apache/hbase/pull/2714#issuecomment-754165376


   @Apache9 Yes the issue is mostly the dependency on Guava. For documenting why a method is visible, unless there is some static analysis (which we don't have and don't use) an annotation is literally just text, no better than a comment placed at the same place in the file. This is not arguable. However as long as we are not taking a (again IMHO useless) Guava dependency for this purpose, I don't have a strong opinion. 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org