You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@dubbo.apache.org by GitBox <gi...@apache.org> on 2022/10/30 12:00:13 UTC
[GitHub] [dubbo] pandaapo opened a new pull request, #10853: fix issue: add new modules and SPIs to shade plugin.
pandaapo opened a new pull request, #10853:
URL: https://github.com/apache/dubbo/pull/10853
## What is the purpose of the change
Fixes #10851
## Brief changelog
Add some new modules and SPIs to maven-shade-plugin.
## Verifying this change
## Checklist
- [x] Make sure there is a [GitHub_issue](https://github.com/apache/dubbo/issues) field for the change (usually before you start working on it). Trivial changes like typos do not require a GitHub issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
- [x] Each commit in the pull request should have a meaningful subject line and body.
- [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
- [ ] Check if is necessary to patch to Dubbo 3 if you are work on Dubbo 2.7
- [ ] Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add sample in [dubbo samples](https://github.com/apache/dubbo-samples) project.
- [ ] Add some description to [dubbo-website](https://github.com/apache/dubbo-website) project if you are requesting to add a feature.
- [ ] GitHub Actions works fine on your own branch.
- [ ] If this contribution is large, please follow the [Software Donation Guide](https://github.com/apache/dubbo/wiki/Software-donation-guide).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo] pandaapo closed pull request #10853: fix issue: add new modules and SPIs to shade plugin.
Posted by "pandaapo (via GitHub)" <gi...@apache.org>.
pandaapo closed pull request #10853: fix issue: add new modules and SPIs to shade plugin.
URL: https://github.com/apache/dubbo/pull/10853
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo] AlbumenJ commented on a diff in pull request #10853: fix issue: add new modules and SPIs to shade plugin.
Posted by GitBox <gi...@apache.org>.
AlbumenJ commented on code in PR #10853:
URL: https://github.com/apache/dubbo/pull/10853#discussion_r1012447176
##########
dubbo-distribution/dubbo-all/pom.xml:
##########
@@ -1119,6 +1129,42 @@
META-INF/dubbo/internal/org.apache.dubbo.validation.Validation
</resource>
</transformer>
+ <transformer
+ implementation="org.apache.maven.plugins.shade.resource.AppendingTransformer">
+ <resource>
+ META-INF/services/org.apache.dubbo.common.extension.LoadingStrategy
+ </resource>
+ </transformer>
+ <transformer
+ implementation="org.apache.maven.plugins.shade.resource.AppendingTransformer">
+ <resource>
+ META-INF/dubbo/internal/org.apache.dubbo.metadata.rest.ServiceRestMetadataResolver
+ </resource>
+ </transformer>
+ <transformer
+ implementation="org.apache.maven.plugins.shade.resource.AppendingTransformer">
+ <resource>
+ META-INF/dubbo/internal/org.apache.dubbo.registry.client.metadata.ServiceInstanceNotificationCustomizer
Review Comment:
Try define a plugin to check if transformers are comprehensive.
##########
dubbo-distribution/dubbo-all/pom.xml:
##########
@@ -468,6 +468,16 @@
<include>org.apache.dubbo:dubbo-compiler</include>
<include>org.apache.dubbo:dubbo-kubernetes</include>
<include>org.apache.dubbo:dubbo-xds</include>
+ <include>org.apache.dubbo:dubbo-filter</include>
+ <include>org.apache.dubbo:dubbo-filter-cache</include>
+ <include>org.apache.dubbo:dubbo-filter-validation</include>
+ <include>org.apache.dubbo:dubbo-spring-boot</include>
+ <include>org.apache.dubbo:dubbo-spring-boot-compatible</include>
+ <include>org.apache.dubbo:dubbo-spring-boot-autoconfigure-compatible</include>
+ <include>org.apache.dubbo:dubbo-spring-boot-autoconfigure</include>
+ <include>org.apache.dubbo:dubbo-spring-boot-starter</include>
+ <include>org.apache.dubbo:dubbo-spring-boot-actuator-compatible</include>
+ <include>org.apache.dubbo:dubbo-spring-boot-actuator</include>
Review Comment:
`dubbo-spring-boot` should not be shaded into `dubbo-all`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org