You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2022/07/26 09:59:46 UTC
[GitHub] [airflow] potiuk opened a new pull request, #25301: Fix too long names of files and docker compose projects
potiuk opened a new pull request, #25301:
URL: https://github.com/apache/airflow/pull/25301
When there is a change spanning multiple providers, the test type
might be very long "Providers[google,microsoft.mssql......]".
Test type is used in generating directory/file names as well as
in determining docker compose project names and such long name might
be just ... too long. But at any point in time we only run one
Provider* test type, so we can simply truncate the "[*]" when we
use TEST_TYPE to determine dir and docker-compose name.
This PR does exactly this.
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of an existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code changes, an Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in a newsfragment file, named `{pr_number}.significant.rst` or `{issue_number}.significant.rst`, in [newsfragments](https://github.com/apache/airflow/tree/main/newsfragments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk merged pull request #25301: Fix too long names of files and docker compose projects
Posted by GitBox <gi...@apache.org>.
potiuk merged PR #25301:
URL: https://github.com/apache/airflow/pull/25301
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] Bowrna commented on pull request #25301: Fix too long names of files and docker compose projects
Posted by GitBox <gi...@apache.org>.
Bowrna commented on PR #25301:
URL: https://github.com/apache/airflow/pull/25301#issuecomment-1195509427
> This is something that is is in progress #23715 and I hope will be finished soon.
Sorry for keeping this in pending for long time @potiuk I am picking this to finish it soon
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #25301: Fix too long names of files and docker compose projects
Posted by GitBox <gi...@apache.org>.
potiuk commented on PR #25301:
URL: https://github.com/apache/airflow/pull/25301#issuecomment-1195334652
> Rather than having to do the same replacement in 4 different places might it be cleaner to set that once in what ever is setting `TEST_TYPE` (and/or introduct a `TEST_TYPE_SAFE`/`TEST_TYPE_CLEAN` variable if there are more uses that want the existing full one)
I thought about it, but we would have to additionally pass this extra variable across multiple levels - from Host script (where we assign the name of docker compose project) to parallel execution script (which executes gnu paralllel) and finally to actual tes execution script (the one that is executed by gnu-parallel). It is totally not worth it especialy that we are going to replace it with new python-based breeze parallelism (as we did with other parts already). This is something that is is in progress #23715 and I hope will be finished soon.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #25301: Fix too long names of files and docker compose projects
Posted by GitBox <gi...@apache.org>.
potiuk commented on PR #25301:
URL: https://github.com/apache/airflow/pull/25301#issuecomment-1195638140
No worries @Bowrna . There are plenty of small things that are distracting fron finish it but we will get there soon enough
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org