[jira] [Commented] (ORC-416) Avoid opening data reader when there is no stripe

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/ORC-416?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16644729#comment-16644729 ] 

ASF GitHub Bot commented on ORC-416:
------------------------------------

dongjoon-hyun opened a new pull request #320: ORC-416: Avoid opening data reader when there is no stripe
URL: https://github.com/apache/orc/pull/320
 
 
   Currently, `RecordReaderImpl` invokes `dataReader.open` in the middle of the constructor. We can postpone this until `advanceToNextRow` reads the stripe at the end of the constructor.
   ```
   this.dataReader.open();
   ```
   This will reduce the chance of potential open-file leakages due to IOException and OOM during `RecordReaderImpl` construction. Also, we can avoid it completely when there is no stripe in the file.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> Avoid opening data reader when there is no stripe
> -------------------------------------------------
>
>                 Key: ORC-416
>                 URL: https://issues.apache.org/jira/browse/ORC-416
>             Project: ORC
>          Issue Type: Bug
>          Components: Java
>    Affects Versions: 1.5.0, 1.5.1, 1.5.2, 1.5.3
>            Reporter: Dongjoon Hyun
>            Priority: Major
>
> Currently, `RecordReaderImpl` invokes `dataReader.open` in the middle of the constructor. We can postpone this until `advanceToNextRow` reads the stripe at the end of the constructor.
> {code:java}
> this.dataReader.open();
> {code}
> This will reduce the chance of potential open-file leakages due to IOException and OOM during `RecordReaderImpl` construction. Also, we can avoid it completely when there is no stripe in the file.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)