[jira] Resolved: (DIRMINA-482) ProfilerTimerFilter synchronizes on a non-final lock object

["Trustin Lee (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/DIRMINA-482?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Trustin Lee resolved DIRMINA-482.
---------------------------------

    Resolution: Fixed
      Assignee: Trustin Lee

Thanks for the patch.  I've just reviewed the filter and changed like the following:

http://svn.apache.org/viewvc?view=rev&revision=597295

> ProfilerTimerFilter synchronizes on a non-final lock object
> -----------------------------------------------------------
>
>                 Key: DIRMINA-482
>                 URL: https://issues.apache.org/jira/browse/DIRMINA-482
>             Project: MINA
>          Issue Type: Improvement
>          Components: Filter
>            Reporter: Tzvika Barenholz
>            Assignee: Trustin Lee
>            Priority: Minor
>         Attachments: ProfilerTimerFilterLocking.diff
>
>
> I found that in the ProfilerTimerFilter  there is a synchronization on an specially created lock object, but it is not declared final. not really a bug, because it is never re-assigned - but a potential bug if someone accidentally assigns it. trivial patch forthcoming.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.