You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@lucene.apache.org by GitBox <gi...@apache.org> on 2021/01/28 23:45:50 UTC
[GitHub] [lucene-solr] madrob opened a new pull request #2266: SOLR-15120 Reduce duplicated core creation work
madrob opened a new pull request #2266:
URL: https://github.com/apache/lucene-solr/pull/2266
Use j.u.c collections instead of sync block
Rework how we load implicit handlers
Additional debug and trace logging for zookeeper comms
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene-solr] madrob commented on a change in pull request #2266: SOLR-15120 Reduce duplicated core creation work
Posted by GitBox <gi...@apache.org>.
madrob commented on a change in pull request #2266:
URL: https://github.com/apache/lucene-solr/pull/2266#discussion_r567320257
##########
File path: solr/core/src/java/org/apache/solr/core/SolrCore.java
##########
@@ -3187,20 +3186,29 @@ public void cleanupOldIndexDirectories(boolean reload) {
}
}
- @SuppressWarnings({"rawtypes"})
- private static final Map implicitPluginsInfo = (Map) Utils.fromJSONResource("ImplicitPlugins.json");
+ private static final class ImplicitHolder {
Review comment:
It was always eager reading from disk and lazy copying the plugins and a messy combination of the two. Now it’s lazy everything the first time, but yea probably could be eager. I don’t think we’re putting in too much complexity this way tho
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene-solr] dsmiley commented on a change in pull request #2266: SOLR-15120 Reduce duplicated core creation work
Posted by GitBox <gi...@apache.org>.
dsmiley commented on a change in pull request #2266:
URL: https://github.com/apache/lucene-solr/pull/2266#discussion_r567274859
##########
File path: solr/core/src/java/org/apache/solr/core/SolrCore.java
##########
@@ -3187,20 +3186,29 @@ public void cleanupOldIndexDirectories(boolean reload) {
}
}
- @SuppressWarnings({"rawtypes"})
- private static final Map implicitPluginsInfo = (Map) Utils.fromJSONResource("ImplicitPlugins.json");
+ private static final class ImplicitHolder {
Review comment:
It appears this is here to lazy-load? But why lazy-load (added complexity of ImplicitHolder wrapper) -- this cost is eventually inescapable since these are needed to load any core, not some obscure/optional feature.
@madrob
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene-solr] madrob merged pull request #2266: SOLR-15120 Reduce duplicated core creation work
Posted by GitBox <gi...@apache.org>.
madrob merged pull request #2266:
URL: https://github.com/apache/lucene-solr/pull/2266
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene-solr] madrob commented on a change in pull request #2266: SOLR-15120 Reduce duplicated core creation work
Posted by GitBox <gi...@apache.org>.
madrob commented on a change in pull request #2266:
URL: https://github.com/apache/lucene-solr/pull/2266#discussion_r567320384
##########
File path: solr/core/src/java/org/apache/solr/core/SolrCore.java
##########
@@ -3187,20 +3186,29 @@ public void cleanupOldIndexDirectories(boolean reload) {
}
}
- @SuppressWarnings({"rawtypes"})
- private static final Map implicitPluginsInfo = (Map) Utils.fromJSONResource("ImplicitPlugins.json");
+ private static final class ImplicitHolder {
Review comment:
I have no problem with this being eager loaded
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org