You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@qpid.apache.org by "Robbie Gemmell (Jira)" <ji...@apache.org> on 2020/08/28 08:24:00 UTC
[jira] [Commented] (DISPATCH-1765) Router version parsing is broken
[ https://issues.apache.org/jira/browse/DISPATCH-1765?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17186378#comment-17186378 ]
Robbie Gemmell commented on DISPATCH-1765:
------------------------------------------
Not so much broken parsing, as not supporting someone screwing with the format in their own custom builds ;)
Using something else besides the version string for feature detection seems reasonable.
If capabilities, note offered capabilities must only be used by the other peer if it also said they were desired capabilities, so the routers would really need to do both (at least one of offered/desired on each side, but perhaps both; depends on usage of the given functionality). If its done with router version string currently, presumably only needed on inter router connections?
> Router version parsing is broken
> --------------------------------
>
> Key: DISPATCH-1765
> URL: https://issues.apache.org/jira/browse/DISPATCH-1765
> Project: Qpid Dispatch
> Issue Type: Bug
> Affects Versions: 1.13.0
> Reporter: Ken Giusti
> Assignee: Ken Giusti
> Priority: Major
> Fix For: 1.14.0
>
>
> The version string advertised by the router in the Open performative may be parsed incorrectly if a non-semantic format is used (e.g. a git commit sha).
> Currently the router uses the router version of its peer in order to determine if the peer supports certain features like streaming links.
> Two changes proposed to solve this:
> 1) do not attempt to parse the version string arriving in the Open performative. Treat it as opaque ascii data.
> 2) Add router-defined capabilities and advertise them in the offered-capabilities field of the Open performative.
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org