[GitHub] betodealmeida commented on a change in pull request #4480: Add https support for Druid

[GitBox <gi...@apache.org>]

betodealmeida commented on a change in pull request #4480: Add https support for Druid
URL: https://github.com/apache/incubator-superset/pull/4480#discussion_r170694906
 
 

 ##########
 File path: superset/connectors/druid/models.py
 ##########
 @@ -107,24 +107,29 @@ def data(self):
             'backend': 'druid',
         }
 
+    @staticmethod
+    def get_base_url(host, port):
+        if not host.startswith('http'):
 
 Review comment:
   It's unlikely, but this might cause problems if the hostname starts with `http`, eg, `http-server.example.com`. I think it's better to use a regex here:
   
   ```python
   if not re.match('http(s)?://', host):
       host = 'http://' + host
   ```

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services