You are viewing a plain text version of this content. The canonical link for it is here.
Posted to yarn-issues@hadoop.apache.org by "Zhankun Tang (JIRA)" <ji...@apache.org> on 2018/11/06 08:49:01 UTC

[jira] [Comment Edited] (YARN-8976) Remove redundant modifiers in interface "ApplicationConstants"

    [ https://issues.apache.org/jira/browse/YARN-8976?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16676348#comment-16676348 ] 

Zhankun Tang edited comment on YARN-8976 at 11/6/18 8:48 AM:
-------------------------------------------------------------

[~cheersyang] . Please help to review.


was (Author: tangzhankun):
[~cheersyang] . Please review.

> Remove redundant modifiers in interface "ApplicationConstants"
> --------------------------------------------------------------
>
>                 Key: YARN-8976
>                 URL: https://issues.apache.org/jira/browse/YARN-8976
>             Project: Hadoop YARN
>          Issue Type: Improvement
>            Reporter: Zhankun Tang
>            Assignee: Zhankun Tang
>            Priority: Trivial
>         Attachments: YARN-8976-trunk.001.patch
>
>
> There're many redundant modifiers in ApplicationContants.java. For instance, "public static final" is redundant due to the String in an interface is implicitly public static final.
> public static final String CLASS_PATH_SEPARATOR = "<CPS>"
> And the redundant public modifier for enums defination and private constructor in interface



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: yarn-issues-help@hadoop.apache.org