You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cordova.apache.org by caereservices <gi...@git.apache.org> on 2017/05/22 15:28:45 UTC
[GitHub] cordova-plugin-splashscreen pull request #126: On Android 7 not work
GitHub user caereservices opened a pull request:
https://github.com/apache/cordova-plugin-splashscreen/pull/126
On Android 7 not work
On Android 7 the plugin seems to ignore <preference> tag in config.xml ... on Android <= 6 it works correctly.
Cordova 7.0.2
Plugin 4.0.4-dev
<!--
Please make sure the checklist boxes are all checked before submitting the PR. The checklist
is intended as a quick reference, for complete details please see our Contributor Guidelines:
http://cordova.apache.org/contribute/contribute_guidelines.html
Thanks!
-->
### Platforms affected
### What does this PR do?
### What testing has been done on this change?
### Checklist
- [ ] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA database
- [ ] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB-xxxx is the JIRA ID & "android" is the platform affected.
- [ ] Added automated test coverage as appropriate for this change.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/apache/cordova-plugin-splashscreen 4.0.x
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-plugin-splashscreen/pull/126.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #126
----
commit 5aebc9c0850ac1025d40938cc7710cb33792c720
Author: Shazron Abdullah <sh...@apache.org>
Date: 2016-12-11T20:58:03Z
CB-12236 - Fixed RELEASENOTES for cordova-plugin-splashscreen
commit 361b8f15c9dd95275cbb20cb468a85f0811354c9
Author: Shazron Abdullah <sh...@apache.org>
Date: 2016-12-08T00:55:08Z
CB-12224 Incremented plugin version.
commit 4ba6c91959d8b77b77089afd18b85967f96faa10
Author: Alexander Sorokin <al...@akvelon.com>
Date: 2016-12-09T10:43:39Z
CB-12230 Removed Windows 8.1 build badges
commit 5172dbbf231e1f5cba4fc1d96e1eb94dfaad0628
Author: Alexander Sorokin <al...@akvelon.com>
Date: 2017-01-18T10:38:07Z
CB-12363 Added build badges for iOS 9.3 and 10.0
commit 3409a86c0b79bbce468414fe18dce7fa3bad4a1f
Author: daserge <v-...@microsoft.com>
Date: 2017-01-18T14:20:23Z
CB-12353 Corrected merges usage in plugin.xml
commit 2e1a6d5d22577fce26ab1d7f695f65eb2e5cacad
Author: Nikita Matrosov <v-...@microsoft.com>
Date: 2017-01-19T13:11:15Z
CB-12369: Add plugin typings from DefinitelyTyped
This closes #123
commit 7045e6c2605136faa0a155f1c5152cf82a949227
Author: Steve Gill <st...@gmail.com>
Date: 2017-03-01T01:41:27Z
CB-12519 Updated version and RELEASENOTES.md for release 4.0.2
commit 3bd0f289d726a2bc950ad58c6f106908748d399f
Author: filmaj <ma...@gmail.com>
Date: 2017-04-27T20:05:10Z
Merge branch 'master' into 4.0.x
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-splashscreen issue #126: On Android 7 not work
Posted by cordova-qa <gi...@git.apache.org>.
Github user cordova-qa commented on the issue:
https://github.com/apache/cordova-plugin-splashscreen/pull/126
Cordova CI Build has completed successfully.
**Commit** - [Link](https://github.com/apache/cordova-plugin-splashscreen/pull/126/commits/3bd0f289d726a2bc950ad58c6f106908748d399f)
**Dashboard** - [Link](http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-splashscreen-pr/49/)
18 tests run, 0 skipped, 0 failed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-splashscreen pull request #126: On Android 7 not work
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-plugin-splashscreen/pull/126
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-splashscreen issue #126: On Android 7 not work
Posted by jcesarmobile <gi...@git.apache.org>.
Github user jcesarmobile commented on the issue:
https://github.com/apache/cordova-plugin-splashscreen/pull/126
Hi.
You have created a Pull Request. Can you close it?
If you want to report a bug, you can do it on issues.cordova.io
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-splashscreen issue #126: On Android 7 not work
Posted by filmaj <gi...@git.apache.org>.
Github user filmaj commented on the issue:
https://github.com/apache/cordova-plugin-splashscreen/pull/126
FYI @jcesarmobile I usually close these kinds of fake PRs via:
```
git commit --allow-empty -m 'Close #126'
```
.. and pushing back up to master. Only way we can do it until Apache gives us more control over GitHub :/
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-splashscreen issue #126: On Android 7 not work
Posted by jcesarmobile <gi...@git.apache.org>.
Github user jcesarmobile commented on the issue:
https://github.com/apache/cordova-plugin-splashscreen/pull/126
@filmaj I know, I've done it a few times, but I like to wait a few days because if the user closes it, we have less empty commits
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org