You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by "derrickaw (via GitHub)" <gi...@apache.org> on 2026/06/02 20:14:04 UTC
[PR] pin commons-configuration2 version to 2.15.0 [beam]
derrickaw opened a new pull request, #38779:
URL: https://github.com/apache/beam/pull/38779
------------------------
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
- [ ] Mention the appropriate issue in your description (for example: `addresses #123`), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment `fixes #<ISSUE NUMBER>` instead.
- [ ] Update `CHANGES.md` with noteworthy changes.
- [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
See the [Contributor Guide](https://beam.apache.org/contribute) for more tips on [how to make review process smoother](https://github.com/apache/beam/blob/master/CONTRIBUTING.md#make-the-reviewers-job-easier).
To check the build health, please visit [https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md](https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md)
GitHub Actions Tests Status (on master branch)
------------------------------------------------------------------------------------------------
[](https://github.com/apache/beam/actions?query=workflow%3A%22Build+python+source+distribution+and+wheels%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Python+Tests%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Java+Tests%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Go+tests%22+branch%3Amaster+event%3Aschedule)
See [CI.md](https://github.com/apache/beam/blob/master/CI.md) for more information about GitHub Actions CI or the [workflows README](https://github.com/apache/beam/blob/master/.github/workflows/README.md) to see a list of phrases to trigger workflows.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] pin commons-configuration2 version to 2.15.0 [beam]
Posted by "derrickaw (via GitHub)" <gi...@apache.org>.
derrickaw commented on PR #38779:
URL: https://github.com/apache/beam/pull/38779#issuecomment-4616293481
R: @Abacn
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] pin commons-configuration2 version to 2.15.0 [beam]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #38779:
URL: https://github.com/apache/beam/pull/38779#issuecomment-4614656460
Assigning reviewers:
R: @liferoad for label build.
Note: If you would like to opt out of this review, comment `assign to next reviewer`.
Available commands:
- `stop reviewer notifications` - opt out of the automated review tooling
- `remind me after tests pass` - tag the comment author after tests pass
- `waiting on author` - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)
The PR bot will only process comments in the main thread (not review comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] pin commons-configuration2 version to 2.15.0 [beam]
Posted by "damccorm (via GitHub)" <gi...@apache.org>.
damccorm commented on code in PR #38779:
URL: https://github.com/apache/beam/pull/38779#discussion_r3405123675
##########
buildSrc/src/main/groovy/org/apache/beam/gradle/BeamModulePlugin.groovy:
##########
@@ -724,8 +724,9 @@ class BeamModulePlugin implements Plugin<Project> {
commons_codec : "commons-codec:commons-codec:1.17.1",
commons_collections : "commons-collections:commons-collections:3.2.2",
commons_compress : "org.apache.commons:commons-compress:1.26.2",
+ commons_configuration2 : "org.apache.commons:commons-configuration2:2.15.0",
Review Comment:
By itself, this won't do anything (you need something like https://github.com/apache/beam/blob/7d642a024a4e9164f72eaf642f95e3725e4d8f7f/sdks/java/io/azure/build.gradle#L35).
Have you confirmed that upgrading commons_io isn't enough? Is there a specific dependency which is pulling this one in?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] pin commons-configuration2 version to 2.15.0 [beam]
Posted by "derrickaw (via GitHub)" <gi...@apache.org>.
derrickaw commented on code in PR #38779:
URL: https://github.com/apache/beam/pull/38779#discussion_r3508392118
##########
buildSrc/src/main/groovy/org/apache/beam/gradle/BeamModulePlugin.groovy:
##########
@@ -724,8 +724,9 @@ class BeamModulePlugin implements Plugin<Project> {
commons_codec : "commons-codec:commons-codec:1.17.1",
commons_collections : "commons-collections:commons-collections:3.2.2",
commons_compress : "org.apache.commons:commons-compress:1.26.2",
+ commons_configuration2 : "org.apache.commons:commons-configuration2:2.15.0",
Review Comment:
This should be done in DataflowTemplates repo. My bad. https://github.com/GoogleCloudPlatform/DataflowTemplates/pull/3966
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] pin commons-configuration2 version to 2.15.0 [beam]
Posted by "gemini-code-assist[bot] (via GitHub)" <gi...@apache.org>.
gemini-code-assist[bot] commented on PR #38779:
URL: https://github.com/apache/beam/pull/38779#issuecomment-4614373366
## Summary of Changes
Hello, I'm Gemini Code Assist[^1]! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request focuses on enhancing the security posture of the project by updating key Apache Commons dependencies. By pinning these libraries to newer, more secure versions, the project mitigates potential vulnerabilities while maintaining compatibility across the build system.
### Highlights
* **Dependency Security Update**: Upgraded commons-configuration2 to version 2.15.0 to address known vulnerabilities.
* **Dependency Compatibility**: Updated commons-io to version 2.19.0 to ensure compatibility with the new commons-configuration2 version.
<details>
<summary><b>New Features</b></summary>
🧠You can now enable **Memory** (public preview) to help **Gemini Code Assist** learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. **Click [here](https://codeassist.google/code-review/login) to enable Memory in your admin console.**
</details>
<details>
<summary><b>Using Gemini Code Assist</b></summary>
<br>
The full guide for Gemini Code Assist can be found on our [documentation page](https://developers.google.com/gemini-code-assist/docs/review-github-code), here are some quick tips.
<b>Invoking Gemini</b>
You can request assistance from Gemini at any point by creating a comment using either `/gemini <command>` or `@gemini-code-assist <command>`. Below is a summary of the supported commands on the current page.
Feature | Command | Description
--- | --- | ---
Code Review | `/gemini review` | Performs a code review for the current pull request in its current state.
Pull Request Summary | `/gemini summary` | Provides a summary of the current pull request in its current state.
Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help | `/gemini help` | Displays a list of available commands.
<b>Customization</b>
To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a `.gemini/` folder in the base of the repository. Detailed instructions can be found [here](https://developers.google.com/gemini-code-assist/docs/customize-gemini-behavior-github).
<b>Limitations & Feedback</b>
Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with :thumbsup: and :thumbsdown: on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up [here](https://google.qualtrics.com/jfe/form/SV_2cyuGuTWsEw84yG).
</details>
[^1]: Review the [Privacy Notices](https://policies.google.com/privacy), [Generative AI Prohibited Use Policy](https://policies.google.com/terms/generative-ai/use-policy), [Terms of Service](https://policies.google.com/terms), and learn how to configure Gemini Code Assist in GitHub [here](https://developers.google.com/gemini-code-assist/docs/customize-gemini-behavior-github). Gemini can make mistakes, so double check it and [use code with caution](https://support.google.com/legal/answer/13505487).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] pin commons-configuration2 version to 2.15.0 [beam]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #38779:
URL: https://github.com/apache/beam/pull/38779#issuecomment-4616303702
Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control. If you'd like to restart, comment `assign set of reviewers`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] pin commons-configuration2 version to 2.15.0 [beam]
Posted by "gemini-code-assist[bot] (via GitHub)" <gi...@apache.org>.
gemini-code-assist[bot] commented on code in PR #38779:
URL: https://github.com/apache/beam/pull/38779#discussion_r3345247656
##########
sdks/java/io/hbase/build.gradle:
##########
@@ -50,3 +50,11 @@ dependencies {
testImplementation("org.apache.hbase:hbase-shaded-testing-util:$hbase_version")
testRuntimeOnly project(path: ":runners:direct-java", configuration: "shadow")
}
+
+configurations.all {
+ resolutionStrategy {
+ // TODO: remove after higher version of hbase (>2.6.5) contains this minimum version.
+ force 'org.apache.commons:commons-configuration2:2.15.0'
Review Comment:
To maintain centralized dependency management, avoid hardcoding the dependency coordinates and version here. Instead, reference the centralized dependency from `BeamModulePlugin.groovy` using `library.java.commons_configuration2`.
```
force library.java.commons_configuration2
```
##########
sdks/java/io/iceberg/hive/build.gradle:
##########
@@ -78,4 +78,8 @@ dependencies {
configurations.all {
// the fatjar "parquet-hadoop-bundle" conflicts with "parquet-hadoop" used by org.apache.iceberg:iceberg-parquet
exclude group: "org.apache.parquet", module: "parquet-hadoop-bundle"
+ // TODO: remove after higher version of hbase (>2.6.5) contains this minimum version.
+ resolutionStrategy {
+ force 'org.apache.commons:commons-configuration2:2.15.0'
Review Comment:
To maintain centralized dependency management, avoid hardcoding the dependency coordinates and version here. Instead, reference the centralized dependency from `BeamModulePlugin.groovy` using `library.java.commons_configuration2`.
```
force library.java.commons_configuration2
```
##########
buildSrc/src/main/groovy/org/apache/beam/gradle/BeamModulePlugin.groovy:
##########
@@ -725,7 +725,7 @@ class BeamModulePlugin implements Plugin<Project> {
commons_collections : "commons-collections:commons-collections:3.2.2",
commons_compress : "org.apache.commons:commons-compress:1.26.2",
commons_csv : "org.apache.commons:commons-csv:1.8",
- commons_io : "commons-io:commons-io:2.16.1",
+ commons_io : "commons-io:commons-io:2.19.0",
Review Comment:
Define `commons_configuration2` centrally in `BeamModulePlugin.groovy` so that it can be referenced across subprojects (like `hbase` and `iceberg`) instead of hardcoding the version string in multiple places.
```
commons_configuration2 : "org.apache.commons:commons-configuration2:2.15.0",
commons_io : "commons-io:commons-io:2.19.0",
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] pin commons-configuration2 version to 2.15.0 [beam]
Posted by "derrickaw (via GitHub)" <gi...@apache.org>.
derrickaw commented on code in PR #38779:
URL: https://github.com/apache/beam/pull/38779#discussion_r3348380812
##########
buildSrc/src/main/groovy/org/apache/beam/gradle/BeamModulePlugin.groovy:
##########
@@ -725,7 +725,7 @@ class BeamModulePlugin implements Plugin<Project> {
commons_collections : "commons-collections:commons-collections:3.2.2",
commons_compress : "org.apache.commons:commons-compress:1.26.2",
commons_csv : "org.apache.commons:commons-csv:1.8",
- commons_io : "commons-io:commons-io:2.16.1",
+ commons_io : "commons-io:commons-io:2.19.0",
Review Comment:
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] pin commons-configuration2 version to 2.15.0 [beam]
Posted by "derrickaw (via GitHub)" <gi...@apache.org>.
derrickaw commented on PR #38779:
URL: https://github.com/apache/beam/pull/38779#issuecomment-4608065520
/gemini review
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] pin commons-configuration2 version to 2.15.0 [beam]
Posted by "derrickaw (via GitHub)" <gi...@apache.org>.
derrickaw closed pull request #38779: pin commons-configuration2 version to 2.15.0
URL: https://github.com/apache/beam/pull/38779
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org