You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@buildstream.apache.org by "gtristan (via GitHub)" <gi...@apache.org> on 2024/07/06 10:07:07 UTC
[PR] Implement `pip` and `junction` origin loading for SourceMirror plugins [buildstream]
gtristan opened a new pull request, #1931:
URL: https://github.com/apache/buildstream/pull/1931
This adds support for loading SourceMirror plugins via both `pip` and `junction` plugin origins.
Testing for this is very basic and does not cover error cases such as circular dependencies.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@buildstream.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Implement `pip` and `junction` origin loading for SourceMirror plugins [buildstream]
Posted by "juergbi (via GitHub)" <gi...@apache.org>.
juergbi commented on PR #1931:
URL: https://github.com/apache/buildstream/pull/1931#issuecomment-2264925189
> The project will not load properly _depending on the order in which the SourceMirrors are declared in `project.conf`_
As long as the behavior is deterministic and this results in a clear error message, I don't think we need to let that issue block this PR. It may be worth a note in the documentation. However, I agree that we likely want to eliminate this limitation at some point.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@buildstream.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Implement `pip` and `junction` origin loading for SourceMirror plugins [buildstream]
Posted by "gtristan (via GitHub)" <gi...@apache.org>.
gtristan merged PR #1931:
URL: https://github.com/apache/buildstream/pull/1931
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@buildstream.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Implement `pip` and `junction` origin loading for SourceMirror plugins [buildstream]
Posted by "gtristan (via GitHub)" <gi...@apache.org>.
gtristan commented on PR #1931:
URL: https://github.com/apache/buildstream/pull/1931#issuecomment-2213620087
Note about remaining imperfections.
We do *not* lazy load the SourceMirror plugins, which means that we load them in a loop, while loading the mirrors configuration in the project configuration, rather than delaying the load until the SourceMirror is actually *used*.
This can still result in some situations where:
* You have two SourceMirror plugins defined through separate junctions
* You need one of these SourceMirrors in order to *access* the other SourceMirror through *its* junction
* The project will not load properly *depending on the order in which the SourceMirrors are declared in `project.conf`*
This is a bit tricky to resolve, and I suspect the current functionality to satisfy the majority of use cases, but we will most likely run into this issue.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@buildstream.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org