You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@commons.apache.org by gg...@apache.org on 2018/06/12 00:21:28 UTC
commons-dbcp git commit: Simplify implementation without using the
catch NPE hack.
Repository: commons-dbcp
Updated Branches:
refs/heads/master 9eb1e0287 -> 3df225721
Simplify implementation without using the catch NPE hack.
Project: http://git-wip-us.apache.org/repos/asf/commons-dbcp/repo
Commit: http://git-wip-us.apache.org/repos/asf/commons-dbcp/commit/3df22572
Tree: http://git-wip-us.apache.org/repos/asf/commons-dbcp/tree/3df22572
Diff: http://git-wip-us.apache.org/repos/asf/commons-dbcp/diff/3df22572
Branch: refs/heads/master
Commit: 3df225721c22a5eb7b7b74e774ffe5a0705965d6
Parents: 9eb1e02
Author: Gary Gregory <ga...@gmail.com>
Authored: Mon Jun 11 18:21:24 2018 -0600
Committer: Gary Gregory <ga...@gmail.com>
Committed: Mon Jun 11 18:21:24 2018 -0600
----------------------------------------------------------------------
src/main/java/org/apache/commons/dbcp2/PoolingDriver.java | 6 +-----
1 file changed, 1 insertion(+), 5 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/commons-dbcp/blob/3df22572/src/main/java/org/apache/commons/dbcp2/PoolingDriver.java
----------------------------------------------------------------------
diff --git a/src/main/java/org/apache/commons/dbcp2/PoolingDriver.java b/src/main/java/org/apache/commons/dbcp2/PoolingDriver.java
index 4272943..2423d19 100644
--- a/src/main/java/org/apache/commons/dbcp2/PoolingDriver.java
+++ b/src/main/java/org/apache/commons/dbcp2/PoolingDriver.java
@@ -145,11 +145,7 @@ public class PoolingDriver implements Driver {
@Override
public boolean acceptsURL(final String url) throws SQLException {
- try {
- return url.startsWith(URL_PREFIX);
- } catch(final NullPointerException e) {
- return false;
- }
+ return url == null ? false : url.startsWith(URL_PREFIX);
}
@Override