You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/12/14 20:22:02 UTC

[GitHub] [arrow-datafusion] alamb commented on issue #4615: Don't ignore failed optimizer rules

alamb commented on issue #4615:
URL: https://github.com/apache/arrow-datafusion/issues/4615#issuecomment-1352109580

   I think the original "ignore optimizer rule if error" was added (maybe by @andygrove  or @avantgardnerio ) because at that time there was no way to distinguish between "Optimizer didn't error but could not handle the query" and "optimizer hit a real error"
   
   Now that `Optimizer::try_optimize` exists, which can distinguish between those two cases,  I think removing `OptimizerRile::optimize` is 👍 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org