You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@commons.apache.org by pa...@apache.org on 2016/06/12 11:27:44 UTC

[2/2] [lang] LANG-1018: add changes.xml entry

LANG-1018: add changes.xml entry

add test for LANG-1187: Method createNumber from NumberUtils doesn't work for floating point numbers other than Float (fixed by LANG-1018)

add test for LANG-1215: NumberUtils.createNumber() method lost precision sometimes (fixed by LANG-1018)

side-effects: close #9, close #7, close #93


Project: http://git-wip-us.apache.org/repos/asf/commons-lang/repo
Commit: http://git-wip-us.apache.org/repos/asf/commons-lang/commit/d2fb3b08
Tree: http://git-wip-us.apache.org/repos/asf/commons-lang/tree/d2fb3b08
Diff: http://git-wip-us.apache.org/repos/asf/commons-lang/diff/d2fb3b08

Branch: refs/heads/master
Commit: d2fb3b0865a87cc909e4faab7733f993356141e2
Parents: 8d6bc0c
Author: pascalschumacher <pa...@gmx.net>
Authored: Sun Jun 12 12:49:15 2016 +0200
Committer: pascalschumacher <pa...@gmx.net>
Committed: Sun Jun 12 13:25:42 2016 +0200

----------------------------------------------------------------------
 src/changes/changes.xml                                        | 1 +
 .../java/org/apache/commons/lang3/math/NumberUtilsTest.java    | 6 ++++++
 2 files changed, 7 insertions(+)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/commons-lang/blob/d2fb3b08/src/changes/changes.xml
----------------------------------------------------------------------
diff --git a/src/changes/changes.xml b/src/changes/changes.xml
index e48726d..8b4e061 100644
--- a/src/changes/changes.xml
+++ b/src/changes/changes.xml
@@ -46,6 +46,7 @@ The <action> type attribute can be add,update,fix,remove.
   <body>
 
   <release version="3.5" date="tba" description="tba">
+    <action issue="LANG-1018" type="fix" dev="pschumacher" due-to="Nick Manley">Fix precision loss on NumberUtils.createNumber(String)</action>
     <action issue="LANG-1229" type="update" dev="pschumacher" due-to="Ruslan Cheremin">HashCodeBuilder.append(Object,Object) is too big to be inlined, which prevents whole builder to be scalarized</action>
     <action issue="LANG-1085" type="add" dev="oheger" due-to="oheger / kinow">Add a circuit breaker implementation</action>
     <action issue="LANG-1013" type="add" dev="pschumacher" due-to="Thiago Andrade">Add StringUtils.truncate()</action>

http://git-wip-us.apache.org/repos/asf/commons-lang/blob/d2fb3b08/src/test/java/org/apache/commons/lang3/math/NumberUtilsTest.java
----------------------------------------------------------------------
diff --git a/src/test/java/org/apache/commons/lang3/math/NumberUtilsTest.java b/src/test/java/org/apache/commons/lang3/math/NumberUtilsTest.java
index e2143bd..9b785f0 100644
--- a/src/test/java/org/apache/commons/lang3/math/NumberUtilsTest.java
+++ b/src/test/java/org/apache/commons/lang3/math/NumberUtilsTest.java
@@ -246,6 +246,12 @@ public class NumberUtilsTest {
         // LANG-1018
         assertEquals("createNumber(String) LANG-1018 failed",
                 Double.valueOf("-160952.54"), NumberUtils.createNumber("-160952.54"));
+        // LANG-1187
+        assertEquals("createNumber(String) LANG-1187 failed",
+                Double.valueOf("6264583.33"), NumberUtils.createNumber("6264583.33"));
+        // LANG-1215
+        assertEquals("createNumber(String) LANG-1215 failed",
+                Double.valueOf("193343.82"), NumberUtils.createNumber("193343.82"));
     }
     
     @Test