You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2021/12/20 02:48:57 UTC

[GitHub] [pulsar] Demogorgon314 commented on a change in pull request #13369: [C++] Adjust clang-format search names

Demogorgon314 commented on a change in pull request #13369:
URL: https://github.com/apache/pulsar/pull/13369#discussion_r772050613



##########
File path: pulsar-client-cpp/README.md
##########
@@ -277,3 +277,23 @@ ${PULSAR_PATH}/pulsar-test-service-stop.sh
 It's recommended to install [LLVM](https://llvm.org/builds/) for `clang-tidy` and `clang-format`. Pulsar C++ client use `clang-format` 5.0 to format files, which is a little different with latest `clang-format`.
 
 We welcome contributions from the open source community, kindly make sure your changes are backward compatible with GCC 4.8 and Boost 1.53.
+
+### Install `clang-format` on macOS
+
+Since the homebrew-core doesn't have `clang-format@5`, here is a tap to install `clang-format@5` in your macOS.

Review comment:
       Thanks for your suggestion. Fixed.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org