You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-issues@hadoop.apache.org by GitBox <gi...@apache.org> on 2022/10/13 22:51:27 UTC
[GitHub] [hadoop] ashutoshcipher opened a new pull request, #5021: MAPREDUCE-7415. Upgrade Junit 4 to 5 in hadoop-mapreduce-client-nativetask
ashutoshcipher opened a new pull request, #5021:
URL: https://github.com/apache/hadoop/pull/5021
### Description of PR
Upgrade Junit 4 to 5 in hadoop-mapreduce-client-nativetask
JIRA - MAPREDUCE-7415
### For code changes:
- [X] Does the title or this PR starts with the corresponding JIRA issue id (e.g. 'HADOOP-17799. Your PR title ...')?
- [ ] Object storage: have the integration tests been executed and the endpoint declared according to the connector-specific documentation?
- [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the `LICENSE`, `LICENSE-binary`, `NOTICE-binary` files?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org
[GitHub] [hadoop] ashutoshcipher commented on pull request #5021: MAPREDUCE-7415. Upgrade Junit 4 to 5 in hadoop-mapreduce-client-nativetask
Posted by GitBox <gi...@apache.org>.
ashutoshcipher commented on PR #5021:
URL: https://github.com/apache/hadoop/pull/5021#issuecomment-1278260908
@aajisaka - Please help in reviewing in your time. Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org
[GitHub] [hadoop] ashutoshcipher commented on pull request #5021: MAPREDUCE-7415. Upgrade Junit 4 to 5 in hadoop-mapreduce-client-nativetask
Posted by GitBox <gi...@apache.org>.
ashutoshcipher commented on PR #5021:
URL: https://github.com/apache/hadoop/pull/5021#issuecomment-1279729139
Fixed some previous stylecheck as well. Current stylecheck showing is not introduced in this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org
[GitHub] [hadoop] aajisaka commented on pull request #5021: MAPREDUCE-7415. Upgrade Junit 4 to 5 in hadoop-mapreduce-client-nativetask
Posted by "aajisaka (via GitHub)" <gi...@apache.org>.
aajisaka commented on PR #5021:
URL: https://github.com/apache/hadoop/pull/5021#issuecomment-1542181727
@ashutoshcipher Jenkins build configuration is set via Apache Yetus and the configuration is implemented in https://github.com/apache/hadoop/blob/trunk/dev-support/bin/hadoop.sh#L274
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org
[GitHub] [hadoop] ashutoshcipher commented on pull request #5021: MAPREDUCE-7415. Upgrade Junit 4 to 5 in hadoop-mapreduce-client-nativetask
Posted by GitBox <gi...@apache.org>.
ashutoshcipher commented on PR #5021:
URL: https://github.com/apache/hadoop/pull/5021#issuecomment-1279729227
@aajisaka - Please help in reviewing it. Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org
[GitHub] [hadoop] hadoop-yetus commented on pull request #5021: MAPREDUCE-7415. Upgrade Junit 4 to 5 in hadoop-mapreduce-client-nativetask
Posted by GitBox <gi...@apache.org>.
hadoop-yetus commented on PR #5021:
URL: https://github.com/apache/hadoop/pull/5021#issuecomment-1278320748
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|:----:|----------:|--------:|:--------:|:-------:|
| +0 :ok: | reexec | 0m 49s | | Docker mode activated. |
|||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 0s | | No case conflicting files found. |
| +0 :ok: | codespell | 0m 1s | | codespell was not available. |
| +0 :ok: | detsecrets | 0m 1s | | detect-secrets was not available. |
| +0 :ok: | xmllint | 0m 1s | | xmllint was not available. |
| +1 :green_heart: | @author | 0m 0s | | The patch does not contain any @author tags. |
| +1 :green_heart: | test4tests | 0m 0s | | The patch appears to include 20 new or modified test files. |
|||| _ trunk Compile Tests _ |
| +1 :green_heart: | mvninstall | 38m 51s | | trunk passed |
| +1 :green_heart: | compile | 1m 10s | | trunk passed with JDK Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04 |
| +1 :green_heart: | compile | 1m 11s | | trunk passed with JDK Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07 |
| +1 :green_heart: | checkstyle | 0m 46s | | trunk passed |
| +1 :green_heart: | mvnsite | 0m 41s | | trunk passed |
| +1 :green_heart: | javadoc | 0m 54s | | trunk passed with JDK Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04 |
| +1 :green_heart: | javadoc | 0m 37s | | trunk passed with JDK Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07 |
| +1 :green_heart: | spotbugs | 1m 7s | | trunk passed |
| +1 :green_heart: | shadedclient | 20m 30s | | branch has no errors when building and testing our client artifacts. |
|||| _ Patch Compile Tests _ |
| +1 :green_heart: | mvninstall | 0m 35s | | the patch passed |
| +1 :green_heart: | compile | 0m 59s | | the patch passed with JDK Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04 |
| +1 :green_heart: | javac | 0m 59s | | the patch passed |
| +1 :green_heart: | compile | 0m 57s | | the patch passed with JDK Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07 |
| +1 :green_heart: | javac | 0m 57s | | the patch passed |
| +1 :green_heart: | blanks | 0m 0s | | The patch has no blanks issues. |
| -0 :warning: | checkstyle | 0m 22s | [/results-checkstyle-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-nativetask.txt](https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5021/1/artifact/out/results-checkstyle-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-nativetask.txt) | hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-nativetask: The patch generated 4 new + 26 unchanged - 35 fixed = 30 total (was 61) |
| +1 :green_heart: | mvnsite | 0m 27s | | the patch passed |
| +1 :green_heart: | javadoc | 0m 24s | | the patch passed with JDK Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04 |
| +1 :green_heart: | javadoc | 0m 23s | | the patch passed with JDK Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07 |
| +1 :green_heart: | spotbugs | 0m 52s | | the patch passed |
| +1 :green_heart: | shadedclient | 20m 7s | | patch has no errors when building and testing our client artifacts. |
|||| _ Other Tests _ |
| +1 :green_heart: | unit | 3m 19s | | hadoop-mapreduce-client-nativetask in the patch passed. |
| +1 :green_heart: | asflicense | 0m 44s | | The patch does not generate ASF License warnings. |
| | | 97m 52s | | |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5021/1/artifact/out/Dockerfile |
| GITHUB PR | https://github.com/apache/hadoop/pull/5021 |
| Optional Tests | dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient codespell detsecrets xmllint spotbugs checkstyle |
| uname | Linux 84221004a9f4 4.15.0-191-generic #202-Ubuntu SMP Thu Aug 4 01:49:29 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/bin/hadoop.sh |
| git revision | trunk / c612792cd38014a76ca42b6d4f1623875909fde4 |
| Default Java | Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07 |
| Multi-JDK versions | /usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07 |
| Test Results | https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5021/1/testReport/ |
| Max. process+thread count | 695 (vs. ulimit of 5500) |
| modules | C: hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-nativetask U: hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-nativetask |
| Console output | https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5021/1/console |
| versions | git=2.25.1 maven=3.6.3 spotbugs=4.2.2 |
| Powered by | Apache Yetus 0.14.0 https://yetus.apache.org |
This message was automatically generated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org
[GitHub] [hadoop] ashutoshcipher commented on pull request #5021: MAPREDUCE-7415. Upgrade Junit 4 to 5 in hadoop-mapreduce-client-nativetask
Posted by "ashutoshcipher (via GitHub)" <gi...@apache.org>.
ashutoshcipher commented on PR #5021:
URL: https://github.com/apache/hadoop/pull/5021#issuecomment-1542170040
@aajisaka
> We should always add -Pnative when compiling Hadoop. (Should be fixed in a separate JIRA)
Can you please share more details? As my understanding this change should be going in Jenkins job. How can I make this change as I dont access to Jenkins job
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org
[GitHub] [hadoop] ashutoshcipher commented on pull request #5021: MAPREDUCE-7415. Upgrade Junit 4 to 5 in hadoop-mapreduce-client-nativetask
Posted by "ashutoshcipher (via GitHub)" <gi...@apache.org>.
ashutoshcipher commented on PR #5021:
URL: https://github.com/apache/hadoop/pull/5021#issuecomment-1542189640
Thanks @aajisaka . I can see ` -Pnative ` is already [there](https://github.com/apache/hadoop/blob/trunk/dev-support/bin/hadoop.sh#L274) . Am I missing something that need to fixed >
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org
[GitHub] [hadoop] aajisaka commented on pull request #5021: MAPREDUCE-7415. Upgrade Junit 4 to 5 in hadoop-mapreduce-client-nativetask
Posted by GitBox <gi...@apache.org>.
aajisaka commented on PR #5021:
URL: https://github.com/apache/hadoop/pull/5021#issuecomment-1383715402
I noticed the tests are skipped in https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5021/1/testReport/org.apache.hadoop.mapred.nativetask.kvtest/KVTest/
Reading the log https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5021/1/console, `-Pnative` option is missing when compiling Hadoop,
```
00:01:04 cd /home/jenkins/jenkins-home/workspace/hadoop-multibranch_PR-5021/ubuntu-focal/src/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-nativetask
00:01:04 /usr/bin/mvn --batch-mode -Dmaven.repo.local=/home/jenkins/jenkins-home/workspace/hadoop-multibranch_PR-5021/yetus-m2/hadoop-trunk-patch-0 -Ptest-patch -DskipTests -fae clean install -DskipTests=true -Dmaven.javadoc.skip=true -Dcheckstyle.skip=true -Dfindbugs.skip=true -Dspotbugs.skip=true > /home/jenkins/jenkins-home/workspace/hadoop-multibranch_PR-5021/ubuntu-focal/out/patch-mvninstall-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-nativetask.txt 2>&1
00:01:25 Elapsed: 0m 35s
```
and only the hadoop-mapreduce-client-nativetask module is later complied with `-Pnative`.
```
00:02:38 cd /home/jenkins/jenkins-home/workspace/hadoop-multibranch_PR-5021/ubuntu-focal/src/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-nativetask
00:02:38 /usr/bin/mvn --batch-mode -Dmaven.repo.local=/home/jenkins/jenkins-home/workspace/hadoop-multibranch_PR-5021/yetus-m2/hadoop-trunk-patch-0 -Ptest-patch -DskipTests -Pnative -Drequire.fuse -Drequire.openssl -Drequire.snappy -Drequire.valgrind -Drequire.zstd -Drequire.test.libhadoop -Pyarn-ui clean test-compile -DskipTests=true > /home/jenkins/jenkins-home/workspace/hadoop-multibranch_PR-5021/ubuntu-focal/out/patch-compile-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-nativetask-jdkPrivateBuild-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07.txt 2>&1
00:03:29 Elapsed: 0m 57s
```
1. We should always add `-Pnative` when compiling Hadoop. (Should be fixed in a separate JIRA)
2. As a workaround, could you make some noop change in hadoop-common module to compile Hadoop native library with `-Pnative`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org
[GitHub] [hadoop] aajisaka commented on a diff in pull request #5021: MAPREDUCE-7415. Upgrade Junit 4 to 5 in hadoop-mapreduce-client-nativetask
Posted by GitBox <gi...@apache.org>.
aajisaka commented on code in PR #5021:
URL: https://github.com/apache/hadoop/pull/5021#discussion_r1070998053
##########
hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-nativetask/src/test/java/org/apache/hadoop/mapred/nativetask/kvtest/KVTest.java:
##########
@@ -89,31 +87,33 @@ public static Iterable<Class<?>[]> data() throws Exception {
// Generate an entry for each key type.
List<Class<?>[]> pairs = Lists.newArrayList();
for (Class<?> keyClass : keyClasses) {
- pairs.add(new Class<?>[]{ keyClass, LongWritable.class });
+ pairs.add(new Class<?>[]{keyClass, LongWritable.class});
}
// ...and for each value type.
for (Class<?> valueClass : valueClasses) {
- pairs.add(new Class<?>[]{ LongWritable.class, valueClass });
+ pairs.add(new Class<?>[]{LongWritable.class, valueClass});
}
return pairs;
}
- private final Class<?> keyclass;
- private final Class<?> valueclass;
+ private Class<?> keyclass;
+ private Class<?> valueclass;
- public KVTest(Class<?> keyclass, Class<?> valueclass) {
+ public void initKVTest(Class<?> keyclass, Class<?> valueclass) {
this.keyclass = keyclass;
this.valueclass = valueclass;
}
- @Before
+ @BeforeEach
public void startUp() throws Exception {
- Assume.assumeTrue(NativeCodeLoader.isNativeCodeLoaded());
- Assume.assumeTrue(NativeRuntime.isNativeLibraryLoaded());
+ Assumptions.assumeTrue(NativeCodeLoader.isNativeCodeLoaded());
+ Assumptions.assumeTrue(NativeRuntime.isNativeLibraryLoaded());
}
- @Test
- public void testKVCompability() throws Exception {
+ @MethodSource("data")
+ @ParameterizedTest(name = "key:{0}\nvalue:{1}")
Review Comment:
Could you verify this name setting works as expected? https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5021/1/testReport/org.apache.hadoop.mapred.nativetask.kvtest/KVTest/
Before this change, the classes are displayed https://ci-hadoop.apache.org/job/hadoop-qbt-trunk-java8-linux-x86_64/1106/testReport/org.apache.hadoop.mapred.nativetask.kvtest/KVTest/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org