You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@shindig.apache.org by "Nik Haldimann (JIRA)" <ji...@apache.org> on 2008/02/15 20:28:09 UTC
[jira] Created: (SHINDIG-72) Parse ModulePrefs attributes such as
description, author etc.
Parse ModulePrefs attributes such as description, author etc.
-------------------------------------------------------------
Key: SHINDIG-72
URL: https://issues.apache.org/jira/browse/SHINDIG-72
Project: Shindig
Issue Type: Improvement
Components: Gadgets Server - Java
Reporter: Nik Haldimann
Assignee: John Hjelmstad
Priority: Minor
Attachments: specparser-improvements.patch
This patch improves GadgetSpecParser to parse more attributes of the ModulePrefs element, namely:
- description
- directory_title
- author
- author_email
- thumbnail
- screenshot
- category and category2
Except for the categories, all of these already had accessors in the GadgetSpec interface. Also changed the type of thumbnail and screenshot to URI. Includes tests and some slight refactorings to reduce code duplication.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (SHINDIG-72) Parse ModulePrefs attributes such as
description, author etc.
Posted by "Nik Haldimann (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-72?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12569388#action_12569388 ]
Nik Haldimann commented on SHINDIG-72:
--------------------------------------
All of these fields are in the extended schema but they are very common. As far as I understand the canonical spec contains everything that is absolutely required to render a gadget. Fields in the extended schema don't influence how a gadget renders. That's a useful distinction and I don't think the canonical schema should be updated to include these attributes.
> Parse ModulePrefs attributes such as description, author etc.
> -------------------------------------------------------------
>
> Key: SHINDIG-72
> URL: https://issues.apache.org/jira/browse/SHINDIG-72
> Project: Shindig
> Issue Type: Improvement
> Components: Gadgets Server - Java
> Reporter: Nik Haldimann
> Assignee: John Hjelmstad
> Priority: Minor
> Attachments: specparser-improvements.patch
>
>
> This patch improves GadgetSpecParser to parse more attributes of the ModulePrefs element, namely:
> - description
> - directory_title
> - author
> - author_email
> - thumbnail
> - screenshot
> - category and category2
> Except for the categories, all of these already had accessors in the GadgetSpec interface. Also changed the type of thumbnail and screenshot to URI. Includes tests and some slight refactorings to reduce code duplication.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (SHINDIG-72) Parse ModulePrefs attributes such as
description, author etc.
Posted by "John Hjelmstad (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-72?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12569410#action_12569410 ]
John Hjelmstad commented on SHINDIG-72:
---------------------------------------
I agree with Nik: the canonical XSD need and should not be updated as a result of acknowledging that these additional fields are useful. For one I think the spec is pretty clear on what must be implemented vs. what optionally can (any given implementation can support a superset).. for another, Shindig must follow the spec, not the other way around.
> Parse ModulePrefs attributes such as description, author etc.
> -------------------------------------------------------------
>
> Key: SHINDIG-72
> URL: https://issues.apache.org/jira/browse/SHINDIG-72
> Project: Shindig
> Issue Type: Improvement
> Components: Gadgets Server - Java
> Reporter: Nik Haldimann
> Assignee: John Hjelmstad
> Priority: Minor
> Attachments: specparser-improvements.patch
>
>
> This patch improves GadgetSpecParser to parse more attributes of the ModulePrefs element, namely:
> - description
> - directory_title
> - author
> - author_email
> - thumbnail
> - screenshot
> - category and category2
> Except for the categories, all of these already had accessors in the GadgetSpec interface. Also changed the type of thumbnail and screenshot to URI. Includes tests and some slight refactorings to reduce code duplication.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (SHINDIG-72) Parse ModulePrefs attributes such as
description, author etc.
Posted by "Paul Lindner (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-72?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12569447#action_12569447 ]
Paul Lindner commented on SHINDIG-72:
-------------------------------------
okay, looks like we're set with decent schemas.. Apologies for commenting..
I have no problem with shindig supporting the extended syntax. If there are no objections I will review and apply this patch.
> Parse ModulePrefs attributes such as description, author etc.
> -------------------------------------------------------------
>
> Key: SHINDIG-72
> URL: https://issues.apache.org/jira/browse/SHINDIG-72
> Project: Shindig
> Issue Type: Improvement
> Components: Gadgets Server - Java
> Reporter: Nik Haldimann
> Assignee: John Hjelmstad
> Priority: Minor
> Attachments: specparser-improvements.patch
>
>
> This patch improves GadgetSpecParser to parse more attributes of the ModulePrefs element, namely:
> - description
> - directory_title
> - author
> - author_email
> - thumbnail
> - screenshot
> - category and category2
> Except for the categories, all of these already had accessors in the GadgetSpec interface. Also changed the type of thumbnail and screenshot to URI. Includes tests and some slight refactorings to reduce code duplication.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (SHINDIG-72) Parse ModulePrefs attributes such as
description, author etc.
Posted by "Nik Haldimann (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-72?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Nik Haldimann updated SHINDIG-72:
---------------------------------
Attachment: specparser-improvements.patch
> Parse ModulePrefs attributes such as description, author etc.
> -------------------------------------------------------------
>
> Key: SHINDIG-72
> URL: https://issues.apache.org/jira/browse/SHINDIG-72
> Project: Shindig
> Issue Type: Improvement
> Components: Gadgets Server - Java
> Reporter: Nik Haldimann
> Assignee: John Hjelmstad
> Priority: Minor
> Attachments: specparser-improvements.patch
>
>
> This patch improves GadgetSpecParser to parse more attributes of the ModulePrefs element, namely:
> - description
> - directory_title
> - author
> - author_email
> - thumbnail
> - screenshot
> - category and category2
> Except for the categories, all of these already had accessors in the GadgetSpec interface. Also changed the type of thumbnail and screenshot to URI. Includes tests and some slight refactorings to reduce code duplication.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (SHINDIG-72) Parse ModulePrefs attributes such as
description, author etc.
Posted by "Bruno Bowden (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-72?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12569383#action_12569383 ]
Bruno Bowden commented on SHINDIG-72:
-------------------------------------
Do we want to have consistency between the canonical spec and Shindig?
This patch recognizes several fields that are in the extended schema for gadgets but not in the canonical schema. The spec is moot on this point except to say the support should be somewhere between the two. I'm not opposed to this change but should update the spec at the same time?
> Parse ModulePrefs attributes such as description, author etc.
> -------------------------------------------------------------
>
> Key: SHINDIG-72
> URL: https://issues.apache.org/jira/browse/SHINDIG-72
> Project: Shindig
> Issue Type: Improvement
> Components: Gadgets Server - Java
> Reporter: Nik Haldimann
> Assignee: John Hjelmstad
> Priority: Minor
> Attachments: specparser-improvements.patch
>
>
> This patch improves GadgetSpecParser to parse more attributes of the ModulePrefs element, namely:
> - description
> - directory_title
> - author
> - author_email
> - thumbnail
> - screenshot
> - category and category2
> Except for the categories, all of these already had accessors in the GadgetSpec interface. Also changed the type of thumbnail and screenshot to URI. Includes tests and some slight refactorings to reduce code duplication.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (SHINDIG-72) Parse ModulePrefs attributes such as
description, author etc.
Posted by "Paul Lindner (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-72?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12569419#action_12569419 ]
Paul Lindner commented on SHINDIG-72:
-------------------------------------
It might be worthwhile to create two xsd files, one for canonical and another extended.
This is actually pretty easy, just reference the canonical xsd and use xs:redefine
A good example of this is here:
http://www.w3schools.com/schema/el_redefine.asp
-- Paul
> Parse ModulePrefs attributes such as description, author etc.
> -------------------------------------------------------------
>
> Key: SHINDIG-72
> URL: https://issues.apache.org/jira/browse/SHINDIG-72
> Project: Shindig
> Issue Type: Improvement
> Components: Gadgets Server - Java
> Reporter: Nik Haldimann
> Assignee: John Hjelmstad
> Priority: Minor
> Attachments: specparser-improvements.patch
>
>
> This patch improves GadgetSpecParser to parse more attributes of the ModulePrefs element, namely:
> - description
> - directory_title
> - author
> - author_email
> - thumbnail
> - screenshot
> - category and category2
> Except for the categories, all of these already had accessors in the GadgetSpec interface. Also changed the type of thumbnail and screenshot to URI. Includes tests and some slight refactorings to reduce code duplication.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (SHINDIG-72) Parse ModulePrefs attributes such as
description, author etc.
Posted by "John Hjelmstad (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-72?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12569415#action_12569415 ]
John Hjelmstad commented on SHINDIG-72:
---------------------------------------
I agree with Nik: the canonical XSD need and should not be updated as a
result of acknowledging that these additional fields are useful. For one I
think the spec is pretty clear on what must be implemented vs. what
optionally can (any given implementation can support a superset).. for
another, Shindig must follow the spec, not the other way around.
On Fri, Feb 15, 2008 at 11:50 AM, Nik Haldimann (JIRA) <ji...@apache.org>
> Parse ModulePrefs attributes such as description, author etc.
> -------------------------------------------------------------
>
> Key: SHINDIG-72
> URL: https://issues.apache.org/jira/browse/SHINDIG-72
> Project: Shindig
> Issue Type: Improvement
> Components: Gadgets Server - Java
> Reporter: Nik Haldimann
> Assignee: John Hjelmstad
> Priority: Minor
> Attachments: specparser-improvements.patch
>
>
> This patch improves GadgetSpecParser to parse more attributes of the ModulePrefs element, namely:
> - description
> - directory_title
> - author
> - author_email
> - thumbnail
> - screenshot
> - category and category2
> Except for the categories, all of these already had accessors in the GadgetSpec interface. Also changed the type of thumbnail and screenshot to URI. Includes tests and some slight refactorings to reduce code duplication.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (SHINDIG-72) Parse ModulePrefs attributes such as
description, author etc.
Posted by "Kevin Brown (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-72?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12569421#action_12569421 ]
Kevin Brown commented on SHINDIG-72:
------------------------------------
This is already the case -- the spec site links to the "canonical" spec (what is required for rendering gadgets) and the "extended" spec (includes meta data that is useful for things like directories as well as other data that has been used by igoogle in the past but doesn't really make sense for other containers)
> Parse ModulePrefs attributes such as description, author etc.
> -------------------------------------------------------------
>
> Key: SHINDIG-72
> URL: https://issues.apache.org/jira/browse/SHINDIG-72
> Project: Shindig
> Issue Type: Improvement
> Components: Gadgets Server - Java
> Reporter: Nik Haldimann
> Assignee: John Hjelmstad
> Priority: Minor
> Attachments: specparser-improvements.patch
>
>
> This patch improves GadgetSpecParser to parse more attributes of the ModulePrefs element, namely:
> - description
> - directory_title
> - author
> - author_email
> - thumbnail
> - screenshot
> - category and category2
> Except for the categories, all of these already had accessors in the GadgetSpec interface. Also changed the type of thumbnail and screenshot to URI. Includes tests and some slight refactorings to reduce code duplication.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Closed: (SHINDIG-72) Parse ModulePrefs attributes such as
description, author etc.
Posted by "Kevin Brown (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-72?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Kevin Brown closed SHINDIG-72.
------------------------------
Resolution: Fixed
Commited in rev 628973
> Parse ModulePrefs attributes such as description, author etc.
> -------------------------------------------------------------
>
> Key: SHINDIG-72
> URL: https://issues.apache.org/jira/browse/SHINDIG-72
> Project: Shindig
> Issue Type: Improvement
> Components: Gadgets Server - Java
> Reporter: Nik Haldimann
> Assignee: John Hjelmstad
> Priority: Minor
> Attachments: specparser-improvements.patch
>
>
> This patch improves GadgetSpecParser to parse more attributes of the ModulePrefs element, namely:
> - description
> - directory_title
> - author
> - author_email
> - thumbnail
> - screenshot
> - category and category2
> Except for the categories, all of these already had accessors in the GadgetSpec interface. Also changed the type of thumbnail and screenshot to URI. Includes tests and some slight refactorings to reduce code duplication.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (SHINDIG-72) Parse ModulePrefs attributes such as
description, author etc.
Posted by "Bruno Bowden (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-72?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12569436#action_12569436 ]
Bruno Bowden commented on SHINDIG-72:
-------------------------------------
As Kevin mentioned. Here's the two schemas:
Canonical: http://code.google.com/apis/gadgets/docs/gadgets-xsd.html
Extended: http://code.google.com/apis/gadgets/docs/gadgets-extended-xsd.html
> Parse ModulePrefs attributes such as description, author etc.
> -------------------------------------------------------------
>
> Key: SHINDIG-72
> URL: https://issues.apache.org/jira/browse/SHINDIG-72
> Project: Shindig
> Issue Type: Improvement
> Components: Gadgets Server - Java
> Reporter: Nik Haldimann
> Assignee: John Hjelmstad
> Priority: Minor
> Attachments: specparser-improvements.patch
>
>
> This patch improves GadgetSpecParser to parse more attributes of the ModulePrefs element, namely:
> - description
> - directory_title
> - author
> - author_email
> - thumbnail
> - screenshot
> - category and category2
> Except for the categories, all of these already had accessors in the GadgetSpec interface. Also changed the type of thumbnail and screenshot to URI. Includes tests and some slight refactorings to reduce code duplication.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.