You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@cordova.apache.org by GitBox <gi...@apache.org> on 2022/01/18 10:10:51 UTC

[GitHub] [cordova-plugin-network-information] ajuanjojjj opened a new pull request #144: Change Navigator.connection types

ajuanjojjj opened a new pull request #144:
URL: https://github.com/apache/cordova-plugin-network-information/pull/144


   ### Platforms affected
   All typescript projects
   
   
   ### Motivation and Context
   Fixes "Wrong typing for Connection" (#143)
   
   
   ### Description
   Adds `dispatchEvent()` to `Navigator.connection`
   Change `Connection.type` from string to `ConnectionType`
   
   
   ### Testing
   Compilating after the changes
   
   
   
   ### Checklist
   - [ ] I've run the tests to see all new and existing tests pass
   - [x] I added automated test coverage as appropriate for this change
   - [x] Commit is prefixed with `(platform)` if this change only applies to one platform (e.g. `(android)`)
   - [x] If this Pull Request resolves an issue, I linked to the issue in the text above 
   - [x] I've updated the documentation if necessary
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org


[GitHub] [cordova-plugin-network-information] ajuanjojjj commented on pull request #144: Change Navigator.connection types

Posted by GitBox <gi...@apache.org>.
ajuanjojjj commented on pull request #144:
URL: https://github.com/apache/cordova-plugin-network-information/pull/144#issuecomment-1015262661


   I tried to run the tests with `npm test`, but seems like there's no .eslintrc file, so eslint fails. 
   
   However, given that this is a TypeScript only issue, I'm not sure it'd do anything, even if the fix introduces problems, unless said file included configuration for the eslint-typescript plugin. Nevertheless, i'd be happy to run further tests if needed


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org