You are viewing a plain text version of this content. The canonical link for it is here.
Posted to general@incubator.apache.org by GitBox <gi...@apache.org> on 2020/12/22 20:25:30 UTC
[GitHub] [incubator] cottage14 opened a new pull request #78: Update transitioning_asf.ad
cottage14 opened a new pull request #78:
URL: https://github.com/apache/incubator/pull/78
Edits for readability. In addition, the original text assumes a migration to a Subversion repository. My colleagues tell me that in the last few years all new podlings have imported their code into Git repositories. It might be a good idea for some wise person to review this page and confirm that it is good guidance for the current reality.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: general-unsubscribe@incubator.apache.org
For additional commands, e-mail: general-help@incubator.apache.org
[GitHub] [incubator] justinmclean commented on a change in pull request #78: Update transitioning_asf.ad
Posted by GitBox <gi...@apache.org>.
justinmclean commented on a change in pull request #78:
URL: https://github.com/apache/incubator/pull/78#discussion_r547545401
##########
File path: pages/guides/transitioning_asf.ad
##########
@@ -18,144 +18,125 @@ Apache Incubator PMC
:toc:
:imagesdir: ../images/
-For corporate contributions, the SGA or CCLA MUST be completed, submitted
-and received before the code is imported.
+For corporate contributions, you MUST complete and submit the SGA or CCLA, and Apache must receive it, before you import code.
For contributions composed of patches from individual contributors,
it is safe to import the code once the major contributors (by volume)
have completed ICLAs or SGAs.
-In either case, the code to be imported should be attached to a JIRA
-and then imported. It is recommended that the previous version
-control system is tagged so that the imported version is precisely known.
+In either case, attach the code to be imported to a JIRA ticket and then import it. We recommend that you tag the previous version
+control system so we know the precise version you are importing.
-A public record MUST be made of the code imported. If the import is not
-attached to JIRA then it MUST be committed to version control.
+You MUST make a public record of the code you import. If you do not attach the import to a JIRA ticket, you MUST committed it to version control.
== Importing History
-The incoming code can either be committed as a snapshot or as a complete version
-control export including history (provided that the import is available in a format
-readable by subversion).
-Importing with history allows existing open source projects who want to maintain
-older versions at Apache to easily perform source diffs and so on. Import just the
+You can commit the incoming code as a snapshot or as a complete version
+control export, including history (provided that the import is available in a format
+readable by Github or Subversion, depending on where the new repository is).
Review comment:
I'd say Git rather than GitHub
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: general-unsubscribe@incubator.apache.org
For additional commands, e-mail: general-help@incubator.apache.org
[GitHub] [incubator] nicknezis merged pull request #78: Update transitioning_asf.ad
Posted by GitBox <gi...@apache.org>.
nicknezis merged pull request #78:
URL: https://github.com/apache/incubator/pull/78
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: general-unsubscribe@incubator.apache.org
For additional commands, e-mail: general-help@incubator.apache.org
[GitHub] [incubator] nicknezis commented on pull request #78: Update transitioning_asf.ad
Posted by GitBox <gi...@apache.org>.
nicknezis commented on pull request #78:
URL: https://github.com/apache/incubator/pull/78#issuecomment-749786439
Apologies, I just realized that this is the apache/incubator repo. I mistakenly thought it was the apache/heron repo, of which I am a committer. I'm sorry if I merged this in too soon.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: general-unsubscribe@incubator.apache.org
For additional commands, e-mail: general-help@incubator.apache.org