You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@inlong.apache.org by do...@apache.org on 2022/09/24 11:59:01 UTC

[inlong] branch master updated: [INLONG-6014][Manager] Int type cannot be compared with null using "==" (#6015)

This is an automated email from the ASF dual-hosted git repository.

dockerzhang pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/inlong.git


The following commit(s) were added to refs/heads/master by this push:
     new dd1b8fdd3 [INLONG-6014][Manager] Int type cannot be compared with null using "==" (#6015)
dd1b8fdd3 is described below

commit dd1b8fdd3bc0c79f8db4d3a62034cf448af2731b
Author: ciscozhou <45...@users.noreply.github.com>
AuthorDate: Sat Sep 24 19:58:56 2022 +0800

    [INLONG-6014][Manager] Int type cannot be compared with null using "==" (#6015)
---
 .../inlong/manager/service/consume/ConsumePulsarOperator.java     | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/inlong-manager/manager-service/src/main/java/org/apache/inlong/manager/service/consume/ConsumePulsarOperator.java b/inlong-manager/manager-service/src/main/java/org/apache/inlong/manager/service/consume/ConsumePulsarOperator.java
index 20d697fe0..5d13d65ee 100644
--- a/inlong-manager/manager-service/src/main/java/org/apache/inlong/manager/service/consume/ConsumePulsarOperator.java
+++ b/inlong-manager/manager-service/src/main/java/org/apache/inlong/manager/service/consume/ConsumePulsarOperator.java
@@ -48,8 +48,8 @@ import org.springframework.stereotype.Service;
 @Service
 public class ConsumePulsarOperator extends AbstractConsumeOperator {
 
-    private static final int DLQ_RLQ_ENABLE = 1;
-    private static final int DLQ__RLQ_DISABLE = 0;
+    private static final Integer DLQ_RLQ_ENABLE = 1;
+    private static final Integer DLQ__RLQ_DISABLE = 0;
     // Topic prefix for the dead letter queue
     private static final String PREFIX_DLQ = "dlq";
     // Topic prefix for the retry letter queue
@@ -116,8 +116,8 @@ public class ConsumePulsarOperator extends AbstractConsumeOperator {
         // prerequisite for RLQ to be turned on: DLQ must be turned on.
         // it means, if DLQ is closed, RLQ cannot exist alone and must be closed.
         ConsumePulsarRequest pulsarRequest = (ConsumePulsarRequest) request;
-        boolean dlqEnable = (DLQ_RLQ_ENABLE == pulsarRequest.getIsDlq());
-        boolean rlqEnable = (DLQ_RLQ_ENABLE == pulsarRequest.getIsRlq());
+        boolean dlqEnable = DLQ_RLQ_ENABLE.equals(pulsarRequest.getIsDlq());
+        boolean rlqEnable = DLQ_RLQ_ENABLE.equals(pulsarRequest.getIsRlq());
         if (rlqEnable && !dlqEnable) {
             throw new BusinessException(ErrorCodeEnum.PULSAR_DLQ_RLQ_ERROR);
         }