[GitHub] [flink] HuangXingBo commented on a change in pull request #10055: [FLINK-14573][python] Support time data types in Python user-defined functions

[GitBox <gi...@apache.org>]

HuangXingBo commented on a change in pull request #10055: [FLINK-14573][python] Support time data types in Python user-defined functions
URL: https://github.com/apache/flink/pull/10055#discussion_r352512187
 
 

 ##########
 File path: flink-python/src/main/java/org/apache/flink/table/runtime/typeutils/serializers/python/TimestampSerializer.java
 ##########
 @@ -0,0 +1,125 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.table.runtime.typeutils.serializers.python;
+
+import org.apache.flink.annotation.Internal;
+import org.apache.flink.api.common.typeutils.SimpleTypeSerializerSnapshot;
+import org.apache.flink.api.common.typeutils.TypeSerializerSnapshot;
+import org.apache.flink.api.common.typeutils.base.TypeSerializerSingleton;
+import org.apache.flink.core.memory.DataInputView;
+import org.apache.flink.core.memory.DataOutputView;
+
+import java.io.IOException;
+import java.sql.Timestamp;
+import java.util.TimeZone;
+
+/**
+ * Takes long instead of a long and a int as the serialized value. It not only reduces the length of
+ * the serialized value, but also makes the serialized value consistent between
+ * the legacy planner and the blink planner.
+ */
+@Internal
+public class TimestampSerializer extends TypeSerializerSingleton<Timestamp> {
+
+	private static final long serialVersionUID = 1L;
+
+	private static final TimeZone LOCAL_TZ = TimeZone.getDefault();
+
+	public static final TimestampSerializer INSTANCE = new TimestampSerializer();
+
+	@Override
+	public boolean isImmutableType() {
+		return false;
+	}
+
+	@Override
+	public Timestamp createInstance() {
+		return new Timestamp(0L);
+	}
+
+	@Override
+	public Timestamp copy(Timestamp from) {
+		if (from == null) {
+			return null;
+		}
+		return new Timestamp(from.getTime());
+	}
+
+	@Override
+	public Timestamp copy(Timestamp from, Timestamp reuse) {
+		if (from == null) {
+			return null;
+		}
+		reuse.setTime(from.getTime());
+		return reuse;
+	}
+
+	@Override
+	public int getLength() {
+		return 8;
+	}
+
+	@Override
+	public void serialize(Timestamp record, DataOutputView target) throws IOException {
+		if (record == null) {
+			throw new IllegalArgumentException("The Timestamp record must not be null.");
+		}
+		target.writeLong(timestampToInternal(record));
+	}
+
+	@Override
+	public Timestamp deserialize(DataInputView source) throws IOException {
+		return internalToTimestamp(source.readLong());
+	}
+
+	private long timestampToInternal(Timestamp ts) {
+		long time = ts.getTime();
+		return time + LOCAL_TZ.getOffset(time);
+	}
+
+	public Timestamp internalToTimestamp(long v) {
+		return new Timestamp(v - LOCAL_TZ.getOffset(v));
 
 Review comment:
   Make sense. I take use of SqlTimestampSerializer to serialize Timestamp value to solve this problem.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services