You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "potiuk (via GitHub)" <gi...@apache.org> on 2023/06/26 06:42:43 UTC

[GitHub] [airflow] potiuk commented on a diff in pull request #32125: Improve provider documentation and README structure

potiuk commented on code in PR #32125:
URL: https://github.com/apache/airflow/pull/32125#discussion_r1241652640


##########
airflow/providers/elasticsearch/CHANGELOG.rst:
##########
@@ -21,15 +21,18 @@
    and you want to add an explanation to the users on how they are supposed to deal with them.
    The changelog is updated and maintained semi-automatically by release manager.
 
-Changelog
----------
+Changelog for ``apache-airflow-providers-elasticsearch``
+--------------------------------------------------------
 
 5.0.0
 .....
 
 .. note::
   Deprecate non-official elasticsearch libraries. Only the official elasticsearch library was used
 
+.. Review and move the new changes to one of the sections above:
+   * ``Deprecate the 2 non-official elasticsearch libraries (#31920)``

Review Comment:
   Nope. Let me review it again - I could have accidentally added it, so let me review all og them



##########
airflow/providers/elasticsearch/CHANGELOG.rst:
##########
@@ -21,15 +21,18 @@
    and you want to add an explanation to the users on how they are supposed to deal with them.
    The changelog is updated and maintained semi-automatically by release manager.
 
-Changelog
----------
+Changelog for ``apache-airflow-providers-elasticsearch``
+--------------------------------------------------------
 
 5.0.0
 .....
 
 .. note::
   Deprecate non-official elasticsearch libraries. Only the official elasticsearch library was used
 
+.. Review and move the new changes to one of the sections above:
+   * ``Deprecate the 2 non-official elasticsearch libraries (#31920)``

Review Comment:
   Nope. Let me review it again - I could have accidentally added it, so let me review all of them



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org