You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@beam.apache.org by jkff <gi...@git.apache.org> on 2016/09/28 23:42:26 UTC

[GitHub] incubator-beam pull request #1023: Deduplicates the 3 in-memory TimerInterna...

GitHub user jkff opened a pull request:

    https://github.com/apache/incubator-beam/pull/1023

    Deduplicates the 3 in-memory TimerInternals

    There were 3 implementations of TimerInternals doing
    basically the same thing:
    - TestTimerInternals in ReduceFnTester
    - TestTimerInternals in TriggerTester
      (these two were nearly identical)
    - BatchTimerInternals
      (it was a subset of the above)
    
    There were also 2 copies of TestInMemoryStateInternals.
    
    This change deduplicates and reorganizes them:
    - Deduplicates the TestInMemoryStateInternals.
      It might make sense to pull its methods into
      InMemoryStateInternals and delete the class, I'm not sure.
    - Factors out the common timer stuff into InMemoryTimerInternals.
    - TriggerTester's implementation of TestTimerInternals
      used to (unnecessarily) access TestInMemoryStateInternals,
      presumably due to copy-paste. Now it uses the regular
      InMemoryTimerInternals.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/jkff/incubator-beam dedup-timer-internals

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-beam/pull/1023.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1023
    
----
commit d671a989a1ba8476ef146d589c589029e258f24b
Author: Eugene Kirpichov <ki...@google.com>
Date:   2016-09-28T22:52:27Z

    Deduplicates the 3 in-memory TimerInternals
    
    There were 3 implementations of TimerInternals doing
    basically the same thing:
    - TestTimerInternals in ReduceFnTester
    - TestTimerInternals in TriggerTester
      (these two were nearly identical)
    - BatchTimerInternals
      (it was a subset of the above)
    
    There were also 2 copies of TestInMemoryStateInternals.
    
    This change deduplicates and reorganizes them:
    - Deduplicates the TestInMemoryStateInternals.
      It might make sense to pull its methods into
      InMemoryStateInternals and delete the class, I'm not sure.
    - Factors out the common timer stuff into InMemoryTimerInternals.
    - TriggerTester's implementation of TestTimerInternals
      used to (unnecessarily) access TestInMemoryStateInternals,
      presumably due to copy-paste. Now it uses the regular
      InMemoryTimerInternals.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-beam pull request #1023: Deduplicates the 3 in-memory TimerInterna...

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/incubator-beam/pull/1023


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---