You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@accumulo.apache.org by GitBox <gi...@apache.org> on 2020/04/08 16:24:38 UTC
[GitHub] [accumulo] andrewglowacki opened a new issue #1581: Move
ThriftClientHandler into a separate file.
andrewglowacki opened a new issue #1581: Move ThriftClientHandler into a separate file.
URL: https://github.com/apache/accumulo/issues/1581
TabletServer is very big. Moving ThriftClientHandler into a separate file would cut its size almost in half. This would also make it easier to continue refactoring TabletServer at a later date. They will still be very tightly coupled.
I can do this if it would be acceptable.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [accumulo] ctubbsii commented on issue #1581: Move
ThriftClientHandler into a separate file.
Posted by GitBox <gi...@apache.org>.
ctubbsii commented on issue #1581: Move ThriftClientHandler into a separate file.
URL: https://github.com/apache/accumulo/issues/1581#issuecomment-611083233
@andrewglowacki I agree. Go ahead and submit a pull request. Please keep the change as minimal as necessary to refactor the class out, in order to lessen the burden on any code reviewers. Any subsequent improvements can be handled in follow-on tasks.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [accumulo] ctubbsii closed issue #1581: Move ThriftClientHandler
into a separate file.
Posted by GitBox <gi...@apache.org>.
ctubbsii closed issue #1581: Move ThriftClientHandler into a separate file.
URL: https://github.com/apache/accumulo/issues/1581
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [accumulo] andrewglowacki commented on issue #1581: Move
ThriftClientHandler into a separate file.
Posted by GitBox <gi...@apache.org>.
andrewglowacki commented on issue #1581: Move ThriftClientHandler into a separate file.
URL: https://github.com/apache/accumulo/issues/1581#issuecomment-611089137
Sounds good, thanks!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services