You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hudi.apache.org by GitBox <gi...@apache.org> on 2020/11/06 09:05:01 UTC
[GitHub] [hudi] Karl-WangSK opened a new pull request #2235: [HUDI-1377] remove duplicate code in HoodieSparkSqlWriter
Karl-WangSK opened a new pull request #2235:
URL: https://github.com/apache/hudi/pull/2235
## *Tips*
- *Thank you very much for contributing to Apache Hudi.*
- *Please review https://hudi.apache.org/contributing.html before opening a pull request.*
## What is the purpose of the pull request
remove duplicate code in HoodieSparkSqlWriter
## Brief change log
found `convertStructTypeToAvroSchema` in `HoodieSparkSqlWriter` twice.It's not necessary
## Verify this pull request
This pull request is a trivial rework / code cleanup without any test coverage.
## Committer checklist
- [x] Has a corresponding JIRA in PR title & commit
- [ ] Commit message is descriptive of the change
- [ ] CI is green
- [ ] Necessary doc changes done or have another open PR
- [ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] vinothchandar merged pull request #2235: [HUDI-1377] remove duplicate code in HoodieSparkSqlWriter
Posted by GitBox <gi...@apache.org>.
vinothchandar merged pull request #2235:
URL: https://github.com/apache/hudi/pull/2235
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] wangxianghu commented on a change in pull request #2235: [HUDI-1377] remove duplicate code in HoodieSparkSqlWriter
Posted by GitBox <gi...@apache.org>.
wangxianghu commented on a change in pull request #2235:
URL: https://github.com/apache/hudi/pull/2235#discussion_r518755565
##########
File path: hudi-spark/src/main/scala/org/apache/hudi/HoodieSparkSqlWriter.scala
##########
@@ -140,7 +140,7 @@ private[hudi] object HoodieSparkSqlWriter {
// Convert to RDD[HoodieRecord]
val keyGenerator = DataSourceUtils.createKeyGenerator(toProperties(parameters))
- val genericRecords: RDD[GenericRecord] = AvroConversionUtils.createRdd(df, structName, nameSpace)
+ val genericRecords: RDD[GenericRecord] = AvroConversionUtils.createRdd(df, schema, structName, nameSpace)
Review comment:
Good Catch
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] vinothchandar commented on pull request #2235: [HUDI-1377] remove duplicate code in HoodieSparkSqlWriter
Posted by GitBox <gi...@apache.org>.
vinothchandar commented on pull request #2235:
URL: https://github.com/apache/hudi/pull/2235#issuecomment-724431419
@Karl-WangSK Thanks for the fix!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] vinothchandar commented on pull request #2235: [HUDI-1377] remove duplicate code in HoodieSparkSqlWriter
Posted by GitBox <gi...@apache.org>.
vinothchandar commented on pull request #2235:
URL: https://github.com/apache/hudi/pull/2235#issuecomment-724431348
@wangxianghu if you are happy I can merge.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] Karl-WangSK commented on pull request #2235: [HUDI-1377] remove duplicate code in HoodieSparkSqlWriter
Posted by GitBox <gi...@apache.org>.
Karl-WangSK commented on pull request #2235:
URL: https://github.com/apache/hudi/pull/2235#issuecomment-723735509
@vinothchandar
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] wangxianghu commented on pull request #2235: [HUDI-1377] remove duplicate code in HoodieSparkSqlWriter
Posted by GitBox <gi...@apache.org>.
wangxianghu commented on pull request #2235:
URL: https://github.com/apache/hudi/pull/2235#issuecomment-724465639
> @Karl-WangSK Thanks for the fix!
yes, you can merge
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] Karl-WangSK commented on pull request #2235: [HUDI-1377] remove duplicate code in HoodieSparkSqlWriter
Posted by GitBox <gi...@apache.org>.
Karl-WangSK commented on pull request #2235:
URL: https://github.com/apache/hudi/pull/2235#issuecomment-723006226
cc @leesf
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org