Re: svn commit: r417203 - in /httpd/httpd/trunk/docs/manual/rewrite: flags.html flags.html.en flags.xml flags.xml.meta

[Joshua Slive <jo...@slive.ca>]

Looks good.  A few nitpicks below.

On 6/26/06, rbowen@apache.org <rb...@apache.org> wrote:
> +<section id="flag_c"><title>C|chain</title>
> +<p>The [C] or [chain] flag indicates that the <directive
> +module="mod_rewrite">RewriteRule</directive> is chained to the next
> +rule. That is, if the rule matches, then it is processed as usual and
> +control moves on to the next rule. However, if it does not match, then
> +the next rule, and any other ruls that are chained together, will be
> +skipped.</p>

Missing an "e" on ruls.  I would also make this a touch more precise
by saying: "If it does not match, then the next rule will be skipped.
The chain can be extended to multiple consecutive rules, with the
first non-matching rule causing the entire remaining chain to be
skipped."

> +<section id="flag_e"><title>E|env</title>
> +<p>With the [E], or [env] flag, you can set the value of an environment
> +variable. Note that some variables may be set after the rule is run, and
> +so setting them in the <directive
> +module="mod_rewrite">RewriteRule</directive> won't work, since it will
> +be changed afterwards.</p>

I don't think that is very precise.  I had to read it a few times to
understand you are talking about variables being overriden before
being passed to CGI scripts.  I suggest simply linking to the env.html
doc, which explains this more explicitly.

Joshua.

---------------------------------------------------------------------
To unsubscribe, e-mail: docs-unsubscribe@httpd.apache.org
For additional commands, e-mail: docs-help@httpd.apache.org

mod_rewrite docs

[Rich Bowen <rb...@rcbowen.com>]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Joshua Slive wrote:
> Looks good.  A few nitpicks below.
...

Thanks for these remarks. I've made these changes.

I'm also trying to split the rewrite guide into common and less common
examples. There's a lot of good stuff in here that is buried, and some
far less useful things that crowd the rest out. If anyone has any
remarks about which rules I've chosen to put in which document, I'd
appreciate the insight. The sorting is neither complete, nor right, and
I'm still trying to figure which should go where, what new rules should
be in here, and what rules should go away entirely.

http://rewrite.drbacchus.com/ was supposed to be a scratchpad where I
could work out that question, and it never really amounted to much. Yet.

- --
Rich Bowen
rbowen@rcbowen.com
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.4 (Darwin)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iD8DBQFEoQZqXP03+sx4yJMRAhhNAKDqJIkmObWxF/xrz3Z7qxV7zuqCzQCdH3ut
84FHyJbcG8piOO9jGj82eDc=
=XFNr
-----END PGP SIGNATURE-----

---------------------------------------------------------------------
To unsubscribe, e-mail: docs-unsubscribe@httpd.apache.org
For additional commands, e-mail: docs-help@httpd.apache.org