You are viewing a plain text version of this content. The canonical link for it is here.
Posted to j-dev@xerces.apache.org by "Michael Glavassevich (JIRA)" <xe...@xml.apache.org> on 2006/02/23 06:26:01 UTC

[jira] Resolved: (XERCESJ-1125) Small enhancements and tweaks for the org.apache.xerces.dom package

     [ http://issues.apache.org/jira/browse/XERCESJ-1125?page=all ]
     
Michael Glavassevich resolved XERCESJ-1125:
-------------------------------------------

    Resolution: Fixed

Thanks Nathan, I've committed your patch to SVN. I made one small modification to the instanceof improvement so that it checks for null. This makes the change equivalent to the cast and catch of the ClassCastException which was there before.

> Small enhancements and tweaks for the org.apache.xerces.dom package
> -------------------------------------------------------------------
>
>          Key: XERCESJ-1125
>          URL: http://issues.apache.org/jira/browse/XERCESJ-1125
>      Project: Xerces2-J
>         Type: Improvement
>   Components: DOM (Level 3 Core)
>     Versions: 2.7.1
>     Reporter: Nathan Beyer
>     Assignee: Michael Glavassevich
>     Priority: Minor
>  Attachments: org_apache_xerces_dom_patches.txt
>
> The attached patch file contains some small code changes. Most of the changes are unnecessary cast removals. The most significant change is changing a cast to an instanceof check in the NodeImpl class. The only thing the cast was doing was attempting to force a ClassCastException. It seems more appropriate to use an instanceof check, as well as less expensive, since an exception is avoided.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


---------------------------------------------------------------------
To unsubscribe, e-mail: j-dev-unsubscribe@xerces.apache.org
For additional commands, e-mail: j-dev-help@xerces.apache.org