You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@teaclave.apache.org by renxingliang <no...@github.com> on 2020/06/20 06:43:55 UTC

[apache/incubator-teaclave] Fix the problem that leveldb parses log file abnormally (#365)

## Description

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context.

Fixes # (issue)

## Type of change (select or add applied and delete the others)

- [ ] Bug fix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
- [ ] API change with a documentation update
- [ ] Additional test coverage
- [ ] Code cleanup or just sync with upstream third-party crates

## How has this been tested?

## Checklist

- [ ] Fork the repo and create your branch from `master`.
- [ ] If you&#39;ve added code that should be tested, add tests.
- [ ] If you&#39;ve changed APIs, update the documentation.
- [ ] Ensure the tests pass (see CI results).
- [ ] Make sure your code lints/format.

You can view, comment on, or merge this pull request online at:

  https://github.com/apache/incubator-teaclave/pull/365

-- Commit Summary --

  * Fix the problem that leveldb parses log file abnormally

-- File Changes --

    M common/rusty_leveldb_sgx/src/log.rs (6)

-- Patch Links --

https://github.com/apache/incubator-teaclave/pull/365.patch
https://github.com/apache/incubator-teaclave/pull/365.diff

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/apache/incubator-teaclave/pull/365

Re: [apache/incubator-teaclave] Fix the problem that leveldb parses log file abnormally (#365)

Posted by Zhaofeng Chen <no...@github.com>.
Hi @renxingliang ,thanks for the information. I think this issue is fixed by #225. Could you please help confirm it still exists? If so, it's better to add a test case for the issue.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/apache/incubator-teaclave/pull/365#issuecomment-647279455

Re: [apache/incubator-teaclave] Fix the problem that leveldb parses log file abnormally (#365)

Posted by renxingliang <no...@github.com>.
Closed #365.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/apache/incubator-teaclave/pull/365#event-3467649230

Re: [apache/incubator-teaclave] Fix the problem that leveldb parses log file abnormally (#365)

Posted by Mingshen Sun <no...@github.com>.
I'm okay with the change. @renxingliang, maybe next time, you can explain a little bit in the PR (follow the template information).

@m4sterchain, please help to confirm this PR. Thanks.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/apache/incubator-teaclave/pull/365#issuecomment-647242956