[PR] nimble/ll: guard central-only functions [mynewt-nimble]

["ItsShunya (via GitHub)" <gi...@apache.org>]

ItsShunya opened a new pull request, #2139:
URL: https://github.com/apache/mynewt-nimble/pull/2139

   **Changes**
   
   - `ble_ll_conn_tx_connect_ind_pducb` is now declared static, as it is only used within ble_ll_conn.c.
   
   The following declarations/definitions are now guarded with `BLE_LL_ROLE_CENTRAL`:
   
   - `g_ble_ll_conn_comp_ev`: its declaration in ble_ll_conn.c is already under `BLE_LL_ROLE_CENTRAL`, so its usage in ble_ll_conn_hci.c is now guarded as well.
   - `ble_ll_conn_hci_create`: its only usage (in ble_ll_hci.c) is already guarded.
   - `ble_ll_conn_hci_ext_create`: same as above.
   - `ble_ll_conn_create_cancel`: same reasoning.
   
   **Rationale**
   
   We recently migrated our codebase to Keil MDK (Armlink), which performs garbage collection after symbol resolution. Due to that difference in link-order behavior, a few unresolved symbols appear when building this project. While I understand this repository does not officially target this toolchain, these changes resolve the linking issues for our setup and also align the guards more consistently across the codebase.
   
   (For context: we are using only the PERIPHERAL role at the moment; other configurations with Keil MDK haven't been tested.)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@mynewt.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] nimble/ll: guard central-only functions [mynewt-nimble]

["sjanc (via GitHub)" <gi...@apache.org>]

sjanc merged PR #2139:
URL: https://github.com/apache/mynewt-nimble/pull/2139


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@mynewt.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] nimble/ll: guard central-only functions [mynewt-nimble]

["ItsShunya (via GitHub)" <gi...@apache.org>]

ItsShunya commented on PR #2139:
URL: https://github.com/apache/mynewt-nimble/pull/2139#issuecomment-3551778207

   I corrected the commit style check and added the static functions that the CI was complaining to the guards too. (ble_ll_conn_hci_create_check_params & ble_ll_conn_hci_ext_create_parse_params, which are only used in CENTRAL functions as well...)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@mynewt.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org