You are viewing a plain text version of this content. The canonical link for it is here.
Posted to log4j-dev@logging.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2015/10/20 09:39:27 UTC
[jira] [Commented] (LOG4J2-1168) Add getters for source and
destination file in file rename action
[ https://issues.apache.org/jira/browse/LOG4J2-1168?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14964717#comment-14964717 ]
ASF GitHub Bot commented on LOG4J2-1168:
----------------------------------------
GitHub user sworisbreathing opened a pull request:
https://github.com/apache/logging-log4j2/pull/17
[LOG4J2-1168] Add source and destination getters for FileRenameAction
Resolves LOG4J2-1168
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/sworisbreathing/logging-log4j2 log4j2-1168
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/logging-log4j2/pull/17.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #17
----
commit 17b52b861b489ae064178be4ba065e284c48c48e
Author: Steve Swor <st...@team.telstra.com>
Date: 2015-10-20T07:38:12Z
[LOG4J2-1168] Add source and destination getters for FileRenameAction
----
> Add getters for source and destination file in file rename action
> -----------------------------------------------------------------
>
> Key: LOG4J2-1168
> URL: https://issues.apache.org/jira/browse/LOG4J2-1168
> Project: Log4j 2
> Issue Type: Improvement
> Components: Appenders, Core
> Reporter: Steven Swor
> Priority: Minor
>
> I'm building a Spring Integration module which leverages log4j2's RollingFileAppender to publish messages whenever the file rolls.
> However, since the FileRenameAction's source and destination files are private and have no getters, I've had to extend that class and copy all of the code DefaultRolloverStrategy to make my implementation work. Since there's a lot of logic in DefaultRolloverStrategy I'd prefer to use the one that ships with log4j, rather than maintaining a fork of the class.
> I'll open a pull request on GitHub shortly.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: log4j-dev-unsubscribe@logging.apache.org
For additional commands, e-mail: log4j-dev-help@logging.apache.org