You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@jena.apache.org by stain <gi...@git.apache.org> on 2014/10/28 17:36:22 UTC

[GitHub] jena pull request: No need for license of derby.log

GitHub user stain opened a pull request:

    https://github.com/apache/jena/pull/9

    No need for license of derby.log

    

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/stain/jena derby-log

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/jena/pull/9.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #9
    
----
commit 2df3083c108b047d4f6f059a27da127a90a70ddc
Author: Stian Soiland-Reyes <so...@cs.manchester.ac.uk>
Date:   2014-10-28T16:35:57Z

    No need for license of derby.log

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] jena pull request: No need for license of derby.log

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/jena/pull/9


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] jena pull request: No need for license of derby.log

Posted by rvesse <gi...@git.apache.org>.
Github user rvesse commented on a diff in the pull request:

    https://github.com/apache/jena/pull/9#discussion_r19487925
  
    --- Diff: jena-parent/pom.xml ---
    @@ -393,6 +393,8 @@
     
                    <exclude>**/log4j.properties</exclude>
                    <exclude>**/log4j-testing.properties</exclude>
    +               <exclude>**/derby.log</exclude>
    +               <exclude>**/DB/**/*</exclude>
    --- End diff --
    
    Do you happen to have a clone that has been around for a while, the `DB` directory was removed from the `jena-text` module a while ago and I had to manually remove it from my workspace (and the Apache Jenkins workspace) to get the builds to pass.
    
    However I don't see any harm in adding the exclusion anyway


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---