[GitHub] [airflow] eladkal commented on a change in pull request #16365: Implemented Tableau Hook connection through SSL

[GitBox <gi...@apache.org>]

eladkal commented on a change in pull request #16365:
URL: https://github.com/apache/airflow/pull/16365#discussion_r649417418



##########
File path: airflow/providers/tableau/hooks/tableau.py
##########
@@ -61,7 +61,9 @@ def __init__(self, site_id: Optional[str] = None, tableau_conn_id: str = default
         self.tableau_conn_id = tableau_conn_id
         self.conn = self.get_connection(self.tableau_conn_id)
         self.site_id = site_id or self.conn.extra_dejson.get('site_id', '')
-        self.server = Server(self.conn.host, use_server_version=True)
+        self.server = Server(self.conn.host)
+        self.server.add_http_options(options_dict={'verify': self.conn.extra_dejson.get('verify', False)})

Review comment:
       if I read the tableau lib code correctly it should be possible to set both verify and cert yet with this change you allow only verify.
   Some like how it is used at:
   https://community.tableau.com/s/question/0D54T00000F33bd/tableauserverclient-signin-with-ssl-certificate
   
   Also why the default is `False`?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org