You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Tamas Mate (Code Review)" <ge...@cloudera.org> on 2022/12/21 13:36:39 UTC
[Impala-ASF-CR] IMPALA-11806: Fix TestIcebergTable.test load E2E test
Tamas Mate has uploaded this change for review. ( http://gerrit.cloudera.org:8080/19385
Change subject: IMPALA-11806: Fix TestIcebergTable.test_load E2E test
......................................................................
IMPALA-11806: Fix TestIcebergTable.test_load E2E test
The test had a flaky part, it was referring to a directory which was
random generated. Removed the referrence to this directory.
The test was failing with filesystems other than HDFS due to the
hdfs_client dependency, replaced the hdfs_client calls to
filesystem_client instead.
Testing:
- Executed the test locally (HDFS/Minicluster)
- Triggered an Ozone build to verify it with different FS
Change-Id: Id95523949aab7dc2417a3d06cf780d3de2e44ee3
---
M testdata/workloads/functional-query/queries/QueryTest/iceberg-load.test
M tests/query_test/test_iceberg.py
2 files changed, 14 insertions(+), 15 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/85/19385/1
--
To view, visit http://gerrit.cloudera.org:8080/19385
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Id95523949aab7dc2417a3d06cf780d3de2e44ee3
Gerrit-Change-Number: 19385
Gerrit-PatchSet: 1
Gerrit-Owner: Tamas Mate <tm...@apache.org>
[Impala-ASF-CR] IMPALA-11806: Fix TestIcebergTable.test load E2E test
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19385 )
Change subject: IMPALA-11806: Fix TestIcebergTable.test_load E2E test
......................................................................
Patch Set 1:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/12053/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/19385
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id95523949aab7dc2417a3d06cf780d3de2e44ee3
Gerrit-Change-Number: 19385
Gerrit-PatchSet: 1
Gerrit-Owner: Tamas Mate <tm...@apache.org>
Gerrit-Reviewer: Anonymous Coward <li...@sensorsdata.cn>
Gerrit-Reviewer: Gergely Fürnstáhl <gf...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Noemi Pap-Takacs <np...@cloudera.com>
Gerrit-Comment-Date: Wed, 21 Dec 2022 13:56:19 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11806: Fix TestIcebergTable.test load E2E test
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/19385 )
Change subject: IMPALA-11806: Fix TestIcebergTable.test_load E2E test
......................................................................
IMPALA-11806: Fix TestIcebergTable.test_load E2E test
The test had a flaky part, it was referring to a directory which was
random generated. Removed the reference to this directory.
The test was failing with filesystems other than HDFS due to the
hdfs_client dependency, replaced the hdfs_client calls to
filesystem_client instead.
Testing:
- Executed the test locally (HDFS/Minicluster)
- Triggered an Ozone build to verify it with different FS
Change-Id: Id95523949aab7dc2417a3d06cf780d3de2e44ee3
Reviewed-on: http://gerrit.cloudera.org:8080/19385
Reviewed-by: Tamas Mate <tm...@apache.org>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
M testdata/workloads/functional-query/queries/QueryTest/iceberg-load.test
M tests/query_test/test_iceberg.py
2 files changed, 14 insertions(+), 15 deletions(-)
Approvals:
Tamas Mate: Looks good to me, approved
Impala Public Jenkins: Verified
--
To view, visit http://gerrit.cloudera.org:8080/19385
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Id95523949aab7dc2417a3d06cf780d3de2e44ee3
Gerrit-Change-Number: 19385
Gerrit-PatchSet: 4
Gerrit-Owner: Tamas Mate <tm...@apache.org>
Gerrit-Reviewer: Anonymous Coward <li...@sensorsdata.cn>
Gerrit-Reviewer: Gergely Fürnstáhl <gf...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Noemi Pap-Takacs <np...@cloudera.com>
Gerrit-Reviewer: Tamas Mate <tm...@apache.org>
[Impala-ASF-CR] IMPALA-11806: Fix TestIcebergTable.test load E2E test
Posted by "Tamas Mate (Code Review)" <ge...@cloudera.org>.
Tamas Mate has uploaded a new patch set (#3). ( http://gerrit.cloudera.org:8080/19385 )
Change subject: IMPALA-11806: Fix TestIcebergTable.test_load E2E test
......................................................................
IMPALA-11806: Fix TestIcebergTable.test_load E2E test
The test had a flaky part, it was referring to a directory which was
random generated. Removed the reference to this directory.
The test was failing with filesystems other than HDFS due to the
hdfs_client dependency, replaced the hdfs_client calls to
filesystem_client instead.
Testing:
- Executed the test locally (HDFS/Minicluster)
- Triggered an Ozone build to verify it with different FS
Change-Id: Id95523949aab7dc2417a3d06cf780d3de2e44ee3
---
M testdata/workloads/functional-query/queries/QueryTest/iceberg-load.test
M tests/query_test/test_iceberg.py
2 files changed, 14 insertions(+), 15 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/85/19385/3
--
To view, visit http://gerrit.cloudera.org:8080/19385
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Id95523949aab7dc2417a3d06cf780d3de2e44ee3
Gerrit-Change-Number: 19385
Gerrit-PatchSet: 3
Gerrit-Owner: Tamas Mate <tm...@apache.org>
Gerrit-Reviewer: Anonymous Coward <li...@sensorsdata.cn>
Gerrit-Reviewer: Gergely Fürnstáhl <gf...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Noemi Pap-Takacs <np...@cloudera.com>
Gerrit-Reviewer: Tamas Mate <tm...@apache.org>
[Impala-ASF-CR] IMPALA-11806: Fix TestIcebergTable.test load E2E test
Posted by "Tamas Mate (Code Review)" <ge...@cloudera.org>.
Tamas Mate has posted comments on this change. ( http://gerrit.cloudera.org:8080/19385 )
Change subject: IMPALA-11806: Fix TestIcebergTable.test_load E2E test
......................................................................
Patch Set 1:
(2 comments)
Thank you for the review Gergo and Noemi!
I am carrying over the +1s.
http://gerrit.cloudera.org:8080/#/c/19385/1//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/19385/1//COMMIT_MSG@10
PS1, Line 10: referrence
> nit: reference
Done
http://gerrit.cloudera.org:8080/#/c/19385/1/testdata/workloads/functional-query/queries/QueryTest/iceberg-load.test
File testdata/workloads/functional-query/queries/QueryTest/iceberg-load.test:
http://gerrit.cloudera.org:8080/#/c/19385/1/testdata/workloads/functional-query/queries/QueryTest/iceberg-load.test@121
PS1, Line 121: has fewer columns (1) than the SELECT / VALUES clause returns (4)
> nit: we could add a "row_regex:Analysis..." to be more precise and just ign
Done
--
To view, visit http://gerrit.cloudera.org:8080/19385
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id95523949aab7dc2417a3d06cf780d3de2e44ee3
Gerrit-Change-Number: 19385
Gerrit-PatchSet: 1
Gerrit-Owner: Tamas Mate <tm...@apache.org>
Gerrit-Reviewer: Anonymous Coward <li...@sensorsdata.cn>
Gerrit-Reviewer: Gergely Fürnstáhl <gf...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Noemi Pap-Takacs <np...@cloudera.com>
Gerrit-Reviewer: Tamas Mate <tm...@apache.org>
Gerrit-Comment-Date: Wed, 21 Dec 2022 17:42:15 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-11806: Fix TestIcebergTable.test load E2E test
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19385 )
Change subject: IMPALA-11806: Fix TestIcebergTable.test_load E2E test
......................................................................
Patch Set 3: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/19385
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id95523949aab7dc2417a3d06cf780d3de2e44ee3
Gerrit-Change-Number: 19385
Gerrit-PatchSet: 3
Gerrit-Owner: Tamas Mate <tm...@apache.org>
Gerrit-Reviewer: Anonymous Coward <li...@sensorsdata.cn>
Gerrit-Reviewer: Gergely Fürnstáhl <gf...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Noemi Pap-Takacs <np...@cloudera.com>
Gerrit-Reviewer: Tamas Mate <tm...@apache.org>
Gerrit-Comment-Date: Wed, 21 Dec 2022 23:08:50 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11806: Fix TestIcebergTable.test load E2E test
Posted by "Noemi Pap-Takacs (Code Review)" <ge...@cloudera.org>.
Noemi Pap-Takacs has posted comments on this change. ( http://gerrit.cloudera.org:8080/19385 )
Change subject: IMPALA-11806: Fix TestIcebergTable.test_load E2E test
......................................................................
Patch Set 1: Code-Review+1
(1 comment)
Nice, LGTM
http://gerrit.cloudera.org:8080/#/c/19385/1//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/19385/1//COMMIT_MSG@10
PS1, Line 10: referrence
nit: reference
--
To view, visit http://gerrit.cloudera.org:8080/19385
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id95523949aab7dc2417a3d06cf780d3de2e44ee3
Gerrit-Change-Number: 19385
Gerrit-PatchSet: 1
Gerrit-Owner: Tamas Mate <tm...@apache.org>
Gerrit-Reviewer: Anonymous Coward <li...@sensorsdata.cn>
Gerrit-Reviewer: Gergely Fürnstáhl <gf...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Noemi Pap-Takacs <np...@cloudera.com>
Gerrit-Comment-Date: Wed, 21 Dec 2022 15:57:40 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-11806: Fix TestIcebergTable.test load E2E test
Posted by "Gergely Fürnstáhl (Code Review)" <ge...@cloudera.org>.
Gergely Fürnstáhl has posted comments on this change. ( http://gerrit.cloudera.org:8080/19385 )
Change subject: IMPALA-11806: Fix TestIcebergTable.test_load E2E test
......................................................................
Patch Set 1: Code-Review+1
(1 comment)
Thanks for fixing this, LGTM!
http://gerrit.cloudera.org:8080/#/c/19385/1/testdata/workloads/functional-query/queries/QueryTest/iceberg-load.test
File testdata/workloads/functional-query/queries/QueryTest/iceberg-load.test:
http://gerrit.cloudera.org:8080/#/c/19385/1/testdata/workloads/functional-query/queries/QueryTest/iceberg-load.test@121
PS1, Line 121: has fewer columns (1) than the SELECT / VALUES clause returns (4)
nit: we could add a "row_regex:Analysis..." to be more precise and just ignore the table name
--
To view, visit http://gerrit.cloudera.org:8080/19385
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id95523949aab7dc2417a3d06cf780d3de2e44ee3
Gerrit-Change-Number: 19385
Gerrit-PatchSet: 1
Gerrit-Owner: Tamas Mate <tm...@apache.org>
Gerrit-Reviewer: Anonymous Coward <li...@sensorsdata.cn>
Gerrit-Reviewer: Gergely Fürnstáhl <gf...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Noemi Pap-Takacs <np...@cloudera.com>
Gerrit-Comment-Date: Wed, 21 Dec 2022 15:31:30 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-11806: Fix TestIcebergTable.test load E2E test
Posted by "Tamas Mate (Code Review)" <ge...@cloudera.org>.
Tamas Mate has posted comments on this change. ( http://gerrit.cloudera.org:8080/19385 )
Change subject: IMPALA-11806: Fix TestIcebergTable.test_load E2E test
......................................................................
Patch Set 3: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/19385
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id95523949aab7dc2417a3d06cf780d3de2e44ee3
Gerrit-Change-Number: 19385
Gerrit-PatchSet: 3
Gerrit-Owner: Tamas Mate <tm...@apache.org>
Gerrit-Reviewer: Anonymous Coward <li...@sensorsdata.cn>
Gerrit-Reviewer: Gergely Fürnstáhl <gf...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Noemi Pap-Takacs <np...@cloudera.com>
Gerrit-Reviewer: Tamas Mate <tm...@apache.org>
Gerrit-Comment-Date: Wed, 21 Dec 2022 17:42:27 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11806: Fix TestIcebergTable.test load E2E test
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19385 )
Change subject: IMPALA-11806: Fix TestIcebergTable.test_load E2E test
......................................................................
Patch Set 3:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/12056/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/19385
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id95523949aab7dc2417a3d06cf780d3de2e44ee3
Gerrit-Change-Number: 19385
Gerrit-PatchSet: 3
Gerrit-Owner: Tamas Mate <tm...@apache.org>
Gerrit-Reviewer: Anonymous Coward <li...@sensorsdata.cn>
Gerrit-Reviewer: Gergely Fürnstáhl <gf...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Noemi Pap-Takacs <np...@cloudera.com>
Gerrit-Reviewer: Tamas Mate <tm...@apache.org>
Gerrit-Comment-Date: Wed, 21 Dec 2022 18:01:59 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11806: Fix TestIcebergTable.test load E2E test
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19385 )
Change subject: IMPALA-11806: Fix TestIcebergTable.test_load E2E test
......................................................................
Patch Set 3:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/8929/ DRY_RUN=false
--
To view, visit http://gerrit.cloudera.org:8080/19385
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id95523949aab7dc2417a3d06cf780d3de2e44ee3
Gerrit-Change-Number: 19385
Gerrit-PatchSet: 3
Gerrit-Owner: Tamas Mate <tm...@apache.org>
Gerrit-Reviewer: Anonymous Coward <li...@sensorsdata.cn>
Gerrit-Reviewer: Gergely Fürnstáhl <gf...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Noemi Pap-Takacs <np...@cloudera.com>
Gerrit-Reviewer: Tamas Mate <tm...@apache.org>
Gerrit-Comment-Date: Wed, 21 Dec 2022 18:03:12 +0000
Gerrit-HasComments: No