You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@dubbo.apache.org by 方银城 <fa...@apache.org> on 2020/02/10 16:45:41 UTC

[VOTE]: Release Apache dubbo-go v1.3.0 RC2

Hello Dubbo/Dubbogo Community,

  This is a call for vote to release Apache dubbo-go version v1.3.0 RC2.

  The release candidates:
https://dist.apache.org/repos/dist/dev/dubbo/dubbo-go/v1.3.0-rc2/

  Git tag for the release: https://github.com/apache/dubbo-go/tree/v1.3.0

  Hash for the release tag: 0d4ba66e996ebb40b895f714d6de304e965ac1fe

  Release Notes: https://github.com/apache/dubbo-go/blob/1.3/CHANGE.md

  The artifacts have been signed with Key :F6C6A49DB4A11314, which can be
found in the keys file: https://dist.apache.org/repos/dist/dev/dubbo/KEYS

  The vote will be open for at least 72 hours or until necessary number of
votes are reached.

 Please vote accordingly:
 [ ] +1 approve
 [ ] +0 no opinion
 [ ] -1 disapprove with the reason

 Thanks,
 The Apache Dubbo-go Team

Re: [VOTE]: Release Apache dubbo-go v1.3.0 RC2

Posted by stocks alex <al...@apache.org>.

Hello,

+1 binding.

I checked:
- signature is ok
- sha512 hash is ok
- no binary fies
- notice is ok

however, I have two suggestions:
- 1 u should not modify the 1.3.0 release notes in CHANGE.md. It will be
better if u add 1.3.0-rc2 release notes into it.
- 2 the contributing.md should have more programming advices.


Justin Mclean <ju...@classsoftware.com> 于2020年2月12日周三 上午10:03写道：

> Hi,
>
> +1 binding but there a minor issue mentioned before that was not fixed.
>
> I checked:
> - signatures and hashes are OK
> - The LICENSE imisisng mention of [1]
> - NOTICE is correct
> - all source files have ASF headers (except [1])
> - no unexpected binary files
> - Again didn’t compile from source. The instruction on how to do this
> could be clearer in the readme.
>
> Thanks,
> Justin
>
> 1. ./protocol/grpc/protoc-gen-dubbo/examples/helloworld.proto

Re: [VOTE]: Release Apache dubbo-go v1.3.0 RC2

Posted by 方银城 <fa...@gmail.com>.

Thanks，we will fix them.

Justin Mclean <ju...@classsoftware.com> 于2020年2月12日周三 上午10:03写道：

> Hi,
>
> +1 binding but there a minor issue mentioned before that was not fixed.
>
> I checked:
> - signatures and hashes are OK
> - The LICENSE imisisng mention of [1]
> - NOTICE is correct
> - all source files have ASF headers (except [1])
> - no unexpected binary files
> - Again didn’t compile from source. The instruction on how to do this
> could be clearer in the readme.
>
> Thanks,
> Justin
>
> 1. ./protocol/grpc/protoc-gen-dubbo/examples/helloworld.proto

Re: [VOTE]: Release Apache dubbo-go v1.3.0 RC2

Posted by Justin Mclean <ju...@classsoftware.com>.

Hi,

+1 binding but there a minor issue mentioned before that was not fixed.

I checked:
- signatures and hashes are OK
- The LICENSE imisisng mention of [1]
- NOTICE is correct
- all source files have ASF headers (except [1])
- no unexpected binary files
- Again didn’t compile from source. The instruction on how to do this could be clearer in the readme.	

Thanks,
Justin

1. ./protocol/grpc/protoc-gen-dubbo/examples/helloworld.proto

Re: [VOTE]: Release Apache dubbo-go v1.3.0 RC2

Posted by "brooks@chtrak.com" <br...@chtrak.com>.

hello 
how to unsubscribe the maillist?



brooks@chtrak.com
 
From: 方银城
Date: 2020-02-11 00:45
To: dev
Subject: [VOTE]: Release Apache dubbo-go v1.3.0 RC2
Hello Dubbo/Dubbogo Community,
 
  This is a call for vote to release Apache dubbo-go version v1.3.0 RC2.
 
  The release candidates:
https://dist.apache.org/repos/dist/dev/dubbo/dubbo-go/v1.3.0-rc2/
 
  Git tag for the release: https://github.com/apache/dubbo-go/tree/v1.3.0
 
  Hash for the release tag: 0d4ba66e996ebb40b895f714d6de304e965ac1fe
 
  Release Notes: https://github.com/apache/dubbo-go/blob/1.3/CHANGE.md
 
  The artifacts have been signed with Key :F6C6A49DB4A11314, which can be
found in the keys file: https://dist.apache.org/repos/dist/dev/dubbo/KEYS
 
  The vote will be open for at least 72 hours or until necessary number of
votes are reached.
 
Please vote accordingly:
[ ] +1 approve
[ ] +0 no opinion
[ ] -1 disapprove with the reason
 
Thanks,
The Apache Dubbo-go Team

Re: [VOTE]: Release Apache dubbo-go v1.3.0 RC2

Posted by Jun Liu <li...@apache.org>.

I vote +1 binding.

I checked:
- signatures and hashes are good
- LICENSE and NOTICE exit and good
- tests can compile and pass
- all source files no binary file

Jun

> On Feb 11, 2020, at 12:45 AM, 方银城 <fa...@apache.org> wrote:
> 
> Hello Dubbo/Dubbogo Community,
> 
>  This is a call for vote to release Apache dubbo-go version v1.3.0 RC2.
> 
>  The release candidates:
> https://dist.apache.org/repos/dist/dev/dubbo/dubbo-go/v1.3.0-rc2/
> 
>  Git tag for the release: https://github.com/apache/dubbo-go/tree/v1.3.0
> 
>  Hash for the release tag: 0d4ba66e996ebb40b895f714d6de304e965ac1fe
> 
>  Release Notes: https://github.com/apache/dubbo-go/blob/1.3/CHANGE.md
> 
>  The artifacts have been signed with Key :F6C6A49DB4A11314, which can be
> found in the keys file: https://dist.apache.org/repos/dist/dev/dubbo/KEYS
> 
>  The vote will be open for at least 72 hours or until necessary number of
> votes are reached.
> 
> Please vote accordingly:
> [ ] +1 approve
> [ ] +0 no opinion
> [ ] -1 disapprove with the reason
> 
> Thanks,
> The Apache Dubbo-go Team