You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@trafficcontrol.apache.org by GitBox <gi...@apache.org> on 2020/10/12 22:09:08 UTC
[GitHub] [trafficcontrol] srijeet0406 opened a new pull request #5142: Return last-modified header only in case of IMS requests
srijeet0406 opened a new pull request #5142:
URL: https://github.com/apache/trafficcontrol/pull/5142
<!--
************ STOP!! ************
If this Pull Request is intended to fix a security vulnerability, DO NOT submit it! Instead, contact
the Apache Software Foundation Security Team at security@trafficcontrol.apache.org and follow the
guidelines at https://www.apache.org/security/ regarding vulnerability disclosure.
-->
## What does this PR (Pull Request) do?
<!-- Explain the changes you made here. If this fixes an Issue, identify it by
replacing the text in the checkbox item with the Issue number e.g.
- [x] This PR fixes #9001 OR is not related to any Issue
^ This will automatically close Issue number 9001 when the Pull Request is
merged (The '#' is important).
Be sure you check the box properly, see the "The following criteria are ALL
met by this PR" section for details.
-->
- [x] This PR is not related to any Issue <!-- You can check for an issue here: https://github.com/apache/trafficcontrol/issues -->
## Which Traffic Control components are affected by this PR?
<!-- Please delete all components from this list that are NOT affected by this
Pull Request. Also, feel free to add the name of a tool or script that is
affected but not on the list.
Additionally, if this Pull Request does NOT affect documentation, please
explain why documentation is not required. -->
- Traffic Ops
## What is the best way to verify this PR?
<!-- Please include here ALL the steps necessary to test your Pull Request. If
it includes tests (and most should), outline here the steps needed to run the
tests. If not, lay out the manual testing procedure and please explain why
tests are unnecessary for this Pull Request. -->
Make sure that the unit tests and API tests pass.
If you're sending a GET request without an IMS header, you should not see a `LAST-MODIFIED` header in the response.
The `LAST-MODIFIED` header should only be present in case there is an IMS header supplied, and the `use_ims` flag is set to true in TO.
## If this is a bug fix, what versions of Traffic Control are affected?
<!-- If this PR fixes a bug, please list here all of the affected versions - to
the best of your knowledge. It's also pretty helpful to include a commit hash
of where 'master' is at the time this PR is opened (if it affects master),
because what 'master' means will change over time. For example, if this PR
fixes a bug that's present in master (at commit hash '1df853c8'), in v4.0.0,
and in the current 4.0.1 Release candidate (e.g. RC1), then this list would
look like:
- master (1df853c8)
- 4.0.0
- 4.0.1 (RC1)
If you don't know what other versions might have this bug, AND don't know how
to find the commit hash of 'master', then feel free to leave this section
blank (or, preferably, delete it entirely).
-->
- master
## The following criteria are ALL met by this PR
<!-- Check the boxes to signify that the associated statement is true. To
"check a box", replace the space inside of the square brackets with an 'x'.
e.g.
- [ x] <- Wrong
- [x ] <- Wrong
- [] <- Wrong
- [*] <- Wrong
- [x] <- Correct!
-->
- [x] This PR includes tests
- [x] I have explained why documentation is unnecessary
- [x] This PR does not include an update to CHANGELOG.md
- [x] This PR includes any and all required license headers
- [x] This PR does not include a database migration
- [x] This PR **DOES NOT FIX A SERIOUS SECURITY VULNERABILITY** (see [the Apache Software Foundation's security guidelines](https://www.apache.org/security/) for details)
## Additional Information
<!-- If you would like to include any additional information on the PR for
potential reviewers please put it here.
Some examples of this would be:
- Before and after screenshots/gifs of the Traffic Portal if it is affected
- Links to other dependent Pull Requests
- References to relevant context (e.g. new/updates to dependent libraries,
mailing list records, blueprints)
Feel free to leave this section blank (or, preferably, delete it entirely).
-->
<!--
Licensed to the Apache Software Foundation (ASF) under one
or more contributor license agreements. See the NOTICE file
distributed with this work for additional information
regarding copyright ownership. The ASF licenses this file
to you under the Apache License, Version 2.0 (the
"License"); you may not use this file except in compliance
with the License. You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing,
software distributed under the License is distributed on an
"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
KIND, either express or implied. See the License for the
specific language governing permissions and limitations
under the License.
-->
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficcontrol] mitchell852 commented on pull request #5142: Return last-modified header only in case of IMS requests
Posted by GitBox <gi...@apache.org>.
mitchell852 commented on pull request #5142:
URL: https://github.com/apache/trafficcontrol/pull/5142#issuecomment-708514641
> Should we not always send `Last-Modified`? What's the reason not to?
> The LM is used to request an `IMS`. If it's not sent initially, users will have to either have custom logic to use the Date the first time (which is less accurate), or make a fake IMS with 1900-01-01 or something.
i think the idea was that if you set use_ims=true in cdn.conf, you'd get the last-modified header with all GET requests and if you set use_ims=false, you were not planning on using the last-modified header so just leave it out.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficcontrol] srijeet0406 commented on pull request #5142: Return last-modified header only in case of IMS requests
Posted by GitBox <gi...@apache.org>.
srijeet0406 commented on pull request #5142:
URL: https://github.com/apache/trafficcontrol/pull/5142#issuecomment-708514882
The reason we removed it in some cases is because if we send a request without an IMS header, we were still adding back a `Last-Modified` header corresponding to the start of time in our response. This was being handled differently by different browsers. For ex, firefox didnt seem to care, where chrome was showing the wrong results in the UI. @mitchell852 and I have been trying to reproduce the issue locally/ on staging unsuccessfully, but @jhg03a was able to. This is more of a "just for safety sake" change.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficcontrol] rob05c commented on pull request #5142: Return last-modified header only in case of IMS requests
Posted by GitBox <gi...@apache.org>.
rob05c commented on pull request #5142:
URL: https://github.com/apache/trafficcontrol/pull/5142#issuecomment-708509238
Should we not always send `Last-Modified`? What's the reason not to?
The LM is used to request an `IMS`. If it's not sent initially, users will have to either have custom logic to use the Date the first time (which is less accurate), or make a fake IMS with 1900-01-01 or something.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficcontrol] mitchell852 merged pull request #5142: Return last-modified header only in case of IMS requests
Posted by GitBox <gi...@apache.org>.
mitchell852 merged pull request #5142:
URL: https://github.com/apache/trafficcontrol/pull/5142
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficcontrol] rawlinp commented on pull request #5142: Return last-modified header only in case of IMS requests
Posted by GitBox <gi...@apache.org>.
rawlinp commented on pull request #5142:
URL: https://github.com/apache/trafficcontrol/pull/5142#issuecomment-708519456
Part of the problem is probably that when use_ims = false, we're always returning `last-modified` with epoch 0. So that is what's changing -- we're no longer sending a default epoch 0 `last-modified` when use_ims = false.
Maybe once use_ims = true has been thoroughly vetted, we can just enable that by default and always return a valid `last-modified`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficcontrol] ocket8888 commented on a change in pull request #5142: Return last-modified header only in case of IMS requests
Posted by GitBox <gi...@apache.org>.
ocket8888 commented on a change in pull request #5142:
URL: https://github.com/apache/trafficcontrol/pull/5142#discussion_r504801242
##########
File path: traffic_ops/traffic_ops_golang/api/shared_handlers.go
##########
@@ -130,6 +130,16 @@ func checkIfOptionsDeleter(obj interface{}, params map[string]string) (bool, err
return false, errors.New("Refusing to delete all resources of type " + name), nil, http.StatusBadRequest
}
+func SetLastModifiedHeader(r *http.Request, useIMS bool) bool {
Review comment:
Can you add a GoDoc to this?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org