You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@kyuubi.apache.org by GitBox <gi...@apache.org> on 2022/07/13 02:31:02 UTC

[GitHub] [incubator-kyuubi] yaooqinn commented on a diff in pull request #3043: Clean up Kyuubi Hive JDBC client

yaooqinn commented on code in PR #3043:
URL: https://github.com/apache/incubator-kyuubi/pull/3043#discussion_r919594440


##########
kyuubi-hive-jdbc/src/main/java/org/apache/kyuubi/jdbc/hive/JdbcColumn.java:
##########
@@ -353,32 +361,4 @@ static int columnScale(int columnType, JdbcColumnAttributes columnAttributes)
         throw new KyuubiSQLException("Invalid column type: " + columnType);
     }
   }
-
-  public Integer getNumPrecRadix() {

Review Comment:
   why delete this public API



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org