You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@subversion.apache.org by pe...@bigfoot.com on 2008/06/17 18:13:06 UTC

Linking of libsvnjavahl-1.jnilib does not use DESTDIR

I believe there's a bug in configure.ac (or configure.in) for Darwin (OSX) 
when a symlink from libsvnjavahl-1.dylib to linsvnjavahl-1.jnilib is 
created... actually there's 2 bugs:

   1) the symlink is created as an absolute link rather then a relative 
link

   2) the symlink is created based on the installation path rather then the 
$DESTDIR/installation path.

I'm not sure if configure.ac is the best place for this change, but here's 
a diff based on configure.ac from subversion-1.5.0-rc9 which corrects both 
problems:

   687c687
   <     INSTALL_EXTRA_JAVAHL_LIB='ln -sf $(libdir)/libsvnjavahl-1.dylib $(libdir)/libsvnjavahl-1.jnilib'
   ---
   >     INSTALL_EXTRA_JAVAHL_LIB='ln -sf libsvnjavahl-1.dylib $(DESTDIR)$(libdir)/libsvnjavahl-1.jnilib'

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org

Re: Linking of libsvnjavahl-1.jnilib does not use DESTDIR

Posted by "Daniel L. Rall" <dl...@finemaltcoding.com>.
On Tue, 17 Jun 2008, petesea@bigfoot.com wrote:

> I believe there's a bug in configure.ac (or configure.in) for Darwin (OSX) 
> when a symlink from libsvnjavahl-1.dylib to linsvnjavahl-1.jnilib is 
> created... actually there's 2 bugs:
> 
>   1) the symlink is created as an absolute link rather then a relative 
> link
> 
>   2) the symlink is created based on the installation path rather then the 
> $DESTDIR/installation path.
> 
> I'm not sure if configure.ac is the best place for this change, but here's 
> a diff based on configure.ac from subversion-1.5.0-rc9 which corrects both 
> problems:
> 
>   687c687
>   <     INSTALL_EXTRA_JAVAHL_LIB='ln -sf $(libdir)/libsvnjavahl-1.dylib 
>   $(libdir)/libsvnjavahl-1.jnilib'
>   ---
>   >     INSTALL_EXTRA_JAVAHL_LIB='ln -sf libsvnjavahl-1.dylib 
>   $(DESTDIR)$(libdir)/libsvnjavahl-1.jnilib'